whimsy
whimsy copied to clipboard
apache
Whimsy failed to find Thanks link
The check result in https://whimsy.apache.org/pods/project/teaclave shows no link to Thanks. However, we have added the Thanks link in http://teaclave.incubator.apache.org/ at the top right of the web page. The source code is in https://github.com/henrysun007/incubator-teaclave-website.
Does anyone know the reason?
The link body includes the following:
(opens new window)
This is not expected to be present as part of the link text.
Given that it is not visible, I wonder what it is doing?
Can opens new window be supported in the future? I think it is acceptable for a link to open a new window.
The purpose of this check is to ensure that at least "Thanks", a common English word, appears in the link text, and it goes to the correct page. There's no policy reason to forbid the extra text, it just requires someone to update and test a new regex for the actual check code:
https://github.com/apache/whimsy/blob/master/lib/whimsy/sitestandards.rb#L71
However that is not what the policy currently says.
As to opening in a separate window, that is not an issue. The text does not actually appear as far as I can tell, and there is anyway an icon which indicates that a new window will be used