tvm icon indicating copy to clipboard operation
tvm copied to clipboard

[Relax] Clean up scatter_elements unknown dtype handling

Open guan404ming opened this issue 2 weeks ago • 1 comments

Why

  • LOG(WARNING) is the standard and correct approach throughout the TVM codebase
  • The existing pattern is used consistently in all relax ops (see test_op_manipulate.py, index.cc, etc.)
  • Added test coverage for previously untested scenarios

guan404ming avatar Dec 10 '25 18:12 guan404ming

Summary of Changes

Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the scatter_elements operator's behavior when encountering unknown data types. It standardizes the warning mechanism to LOG(WARNING) and removes outdated TODO comments, aligning with existing TVM codebase practices. Additionally, it enhances test coverage to ensure proper handling of previously untested scenarios involving unknown data and update tensor data types.

Highlights

  • Standardized Warning Mechanism: The handling of unknown data types in the scatter_elements operator now consistently uses LOG(WARNING), aligning with standard practices across the TVM codebase.
  • Removed TODO Comments: Outdated TODO comments related to warning reporting for unknown data types in InferStructInfoScatterElements have been removed.
  • Enhanced Test Coverage: New test cases have been added for scatter_elements to specifically cover scenarios where the data or updates tensors have unknown data types, ensuring more robust behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 10 '25 18:12 gemini-code-assist[bot]

cc @tlopex @mshr-h

guan404ming avatar Dec 11 '25 00:12 guan404ming