tvm icon indicating copy to clipboard operation
tvm copied to clipboard
verified publisher icon apache

[CI Problem] Windows Conda Build Does Not Support C++20 Features

Open zxybazh opened this issue 1 year ago • 3 comments

The windows conda build would fail because it doesn't support c++20 feature such as designated initializer.

Branch/PR Failing

https://github.com/apache/tvm/pull/16717/commits/a5bbfcc9dd068e9a069f3dce3e06535a85bca66e

Jenkins Link

Provide a link to the specific run that has failed.

Flakiness

Reproduces in the same PR for different commits.

Triage

Please refer to the list of label tags here to find the relevant tags and add them below in a bullet format (example below).

  • needs-triage

zxybazh avatar Mar 14 '24 21:03 zxybazh

Can we first update to make it cxx17 compatible?

tqchen avatar Mar 15 '24 17:03 tqchen

we are still using c++17, the error is because c++20 is not enabled

vinx13 avatar Mar 15 '24 18:03 vinx13

Original PR #16717 has been updated to make it c++17 compatible and passed the CI. This issue is created to mark that c++20 features may cause windows CI to fail during conda build.

zxybazh avatar Mar 15 '24 18:03 zxybazh

Won't fix for now. Please feel free to reopen if this reproduces.

zxybazh avatar Sep 13 '24 21:09 zxybazh