tvm icon indicating copy to clipboard operation
tvm copied to clipboard

Published 20 hours ago • verified publisher icon apache

[BugFix][UMA] Bugfix of target attr and fixed link in tutorial

Open MichaelJKlaiber opened this issue 2 years ago • 3 comments

There was a flaw in UMA backend.py that triggered an error when for passing target attributes. It is fixed.

A link in the UMA tutorial was broken and fixed by this PR.

MichaelJKlaiber avatar Sep 08 '22 09:09 MichaelJKlaiber

@cgerum @areusch

MichaelJKlaiber avatar Sep 08 '22 09:09 MichaelJKlaiber

@areusch, @manupak , what are your 2cents here?

This seems like a minor fix.

MichaelJKlaiber avatar Sep 13 '22 09:09 MichaelJKlaiber

thanks @MichaelJKlaiber ! agreed with the others that it would be great if we could update the test to cover this case as well

areusch avatar Sep 15 '22 21:09 areusch

@MichaelJKlaiber

  • The bug annoyed UMA initialisation, thanks for the fix !

@areusch , @manupak, @lhutton1

  • LGTM, confirming that in real practice the issue is fixed.

Can this be moved forward and merged ?

cbalint13 avatar Dec 12 '22 19:12 cbalint13

Closing as this PR is superseded by #13624

lhutton1 avatar Dec 16 '22 13:12 lhutton1