tvm
tvm copied to clipboard
[ci] Add CSI-NN2 build to Jenkins
add build script for csinn.
cc @Mousius @areusch @driazati @gigiblender
hi @driazati, thanks for your comments!
commented out code should be removed or have some context, I don't see
USE_CSINN
inCMakeLists.txt
, is there anything that needs to be done in the build to enable CSI-NN2?
hi @driazati , Sorry, I'm a little confused here about the order of submitting Jenkins changes and submitting code changes. because Jenkins has a security feature where it won't parse the Jenkinsfile modified by a PR. If the Jenkins changes is submitted first, there is no code to build. If the code changes is submitted first, the code will not run because it has not been built. Because of this problem, I submitted an empty build config script in this pr. After that, when the code is submitted, the actual content of this part will be added.
thanks!
we can do it all in one PR, I'll push your changes to https://github.com/apache/tvm/tree/csinn_jenkins once updated so Jenkins will use your changed Jenkinsfile
in another build check called tvm-ci/branch
. So the one in tvm-ci/pr-head
will just see a bunch of new files added and no real changes (which is fine here).
ah i see--sorry i was a bit misleading in my earlier comment @alter-xp. it is indeed possible to do it all at once, but if there's significant debugging on the non-Jenkinsfile part, then it makes your debug iteration time quite long and impractical. I'm good with either approach here. you could also just remove the commented code to reduce interim confusion (or add a TODO comment) and then follow-on with another PR.
thanks @driazati @areusch ! I got it. I removed the comment code.
hi @areusch @driazati , cI/Android check failed, but the error message does not seem to be related to this PR. Have you ever encountered such a situation? Is there any solution to this?
thanks @driazati, the compilation directory are missing from the generated command of running ./tests/scripts/task_build.py. I have added this content. Please help me review again.
retriggered CI since it appears pr-head passed.
ah shoot, this PR got conflicted. @alter-xp can you rebase?
hi @areusch @driazati, CI for build GPU failed, which seems to be because of what I added about --build_dir
. The GPU has two build scripts. The code shows that they are compiled in two folders. But in fact, it looks like that they need to be compiled in one folder. Do you know what it should be like?
hi @areusch @driazati, CI for build GPU failed, which seems to be because of what I added about
--build_dir
. The GPU has two build scripts. The code shows that they are compiled in two folders. But in fact, it looks like that they need to be compiled in one folder. Do you know what it should be like?
I think it's been broken this whole time and just wasn't running, then the fix you made to make()
actually turned it on. I pushed a commit to disable it so that we can merge this PR then I'll deal with it in a follow up (see #12739).
I think it's been broken this whole time and just wasn't running, then the fix you made to
make()
actually turned it on. I pushed a commit to disable it so that we can merge this PR then I'll deal with it in a follow up (see #12739).
thanks @driazati !
hey @alter-xp i'm just coming back from PTO and wanted to check in on this effort. anything we can do to help get this PR in?
Thanks @areusch . Previously, this branch was blocked due to the ci problem. Now it seems that the problem has been fixed. I will continue to push this pr.
hi @areusch, there's a small issue here that needs your help. If I want to update the csinn version in ubuntu_download_csinn2_compute_lib.sh, do I need to manually update the docker image?