tvm icon indicating copy to clipboard operation
tvm copied to clipboard

Published 20 hours ago • verified publisher icon apache

[TFLite] Support quantized GREATER op in TFLite frontend

Open dchauhan-arm opened this issue 2 years ago • 7 comments

Support GREATER quantization operation conversion as part of issue #9187

dchauhan-arm avatar Jun 01 '22 08:06 dchauhan-arm

cc @leandron and @lhutton1 for a second look

dchauhan-arm avatar Jun 22 '22 09:06 dchauhan-arm

@dchauhan-arm just a friendly ping to update this PR with quantised testing for the operator.

yes, what I think I'll do is rewrite a test specifically for the greater op, and compare output of tvm against tflite.

dchauhan-arm avatar Jun 28 '22 14:06 dchauhan-arm

@lhutton1 can you have another look on this one?

leandron avatar Jul 19 '22 11:07 leandron

I believe its still waiting on an update, @dchauhan-arm please let me know if that's not the case

lhutton1 avatar Jul 19 '22 12:07 lhutton1

cc @lhutton1 for a second (second) look

dchauhan-arm avatar Jul 20 '22 07:07 dchauhan-arm

hmmm looks like there's a seg fault happening in test_elemwise[_test_greater] on aarch64 CI, so maybe there is an issue with this version of tensorflow on aarch64

lhutton1 avatar Jul 20 '22 17:07 lhutton1

With tflite 2.9.1 test_elemwise[_test_greater] does not fail any more. We should wait for #12130 and #12131 to be merged.

NicolaLancellotti avatar Jul 26 '22 15:07 NicolaLancellotti

This is now unblocked by https://github.com/apache/tvm/pull/12738 - @dchauhan-arm can you remove the conflict and resubmit this for CI to check?

leandron avatar Sep 09 '22 15:09 leandron