trafodion icon indicating copy to clipboard operation
trafodion copied to clipboard

[TRAFODION-2920]Add hibernate dialect support.

Open xlloveyun opened this issue 7 years ago • 13 comments

xlloveyun avatar Jan 19 '18 04:01 xlloveyun

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 19 '18 04:01 Traf-Jenkins

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 19 '18 04:01 Traf-Jenkins

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 19 '18 04:01 Traf-Jenkins

Can one of the admins verify this patch?

Traf-Jenkins avatar Jan 19 '18 04:01 Traf-Jenkins

+1 Good!

uamgo avatar Jan 19 '18 06:01 uamgo

I have a concern here. Maven POM is set to pull in the hibernate-core dependency, which appears to be licensed under LGPL. That is not something we can bundle.

svarnau avatar Jan 19 '18 17:01 svarnau

@svarnau, did the latest change answer your concern?

DaveBirdsall avatar Feb 08 '18 00:02 DaveBirdsall

No, my concern is not addressed. There is still license issue with the hibernate dependency, as far as I can see.

svarnau avatar Feb 08 '18 17:02 svarnau

I don't familiar with the license issue. Is there any document saying we can not use? As i know if we want to make any changes on the source code, it should involve license issue. We also did use Python which is GPL license in DCS pom.xml. What do you think or any body we could ask?

uamgo avatar Feb 11 '18 07:02 uamgo

Looked a pom.xml in Apache Spark and some of the dependencies are not from Apache. So I think it might be ok( correct me if i am wrong).

uamgo avatar Feb 11 '18 10:02 uamgo

http://apache.org/legal/resolved.html#category-x

The DCS dependency you mention is jython-standalone, which has a different license, and is regferenced in our license file(s).

svarnau avatar Feb 12 '18 05:02 svarnau

Can one of the admins verify this patch?

Traf-Jenkins avatar Aug 01 '18 20:08 Traf-Jenkins

Can one of the admins verify this patch?

Traf-Jenkins avatar Aug 01 '18 20:08 Traf-Jenkins