trafficserver
trafficserver copied to clipboard
File change monitoring on s3_auth (#8905)
- Add a file change monitoring API to iocore.
- Use it to add config change monitoring to s3_auth. This can be used to rotate s3_auth secrets.
(Previously I made PR #8905 against 9.2.x by mistake. It should have been against master branch. This PR is rebased on top of master. It also incorporates an autest change suggested by @bneradt.)
Looks like the gold file doesn't quite match curl's output: https://ci.trafficserver.apache.org/job/Github_Builds/job/autest/1219/console
Probably good to replace lines that aren't strictly relevant to the test output with ``.
In case it's helpful, issues like this make me lean toward using Proxy Verifier in AuTests. It has a purpose built field verification mechanism rather than the generic gold comparison.
My text editor trimmed trailing whitespace from the gold file. It looks like the other gold file to match ATS log output also failed. I'm investigating.
Autest failure should be fixed with latest push. Thanks @bneradt
Also, removing 9.2.x from this, we'll add this new API and plugin changes for 10.0.x.
Couple of things to do before we can merge:
- This needs to be discussed on the mailing list, as is the normal process for adding new plugin APIs. A short description of the new APIs, with the prototypes etc., and a justification.
- These new APIs only work on Linux, which I feel reasonably strongly is not acceptable. I don't think we have any other APIs that are Linux only. So, we'll need to add kqueue support to this as well please :).
- API description sent to mailing list.
- kqueue implementation now added.
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.