trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Use Persistent Memory as storage for disk cache

Open cukiernik opened this issue 2 years ago • 7 comments

Allows use the Intel Optane Persistent Memory as a storage for cache. It map storage directly into user space memory, so reads and writes are doing by a memcpy (without calls an io).

For configure use script tools/ipm-configure. It be need restart system probably, and run again. It configure PMem into AppDirect mode, and configure nemespaces to devdax mode. Data stored in them, be able after restart.

cukiernik avatar Apr 19 '22 15:04 cukiernik

https://github.com/apache/trafficserver/issues/8693

cukiernik avatar Apr 25 '22 13:04 cukiernik

@SolidWallOfCode is going to review this

bryancall avatar Apr 25 '22 23:04 bryancall

@moonchen will review this

bryancall avatar Apr 25 '22 23:04 bryancall

Can You help mi about RAT fail? It be ok, if I put Intel Open Source License into headers?

cukiernik avatar Apr 26 '22 14:04 cukiernik

Can You help mi about RAT fail? It be ok, if I put Intel Open Source License into headers?

It's just alerting that some of the new files do not have valid license headers:

  • ./tools/ipm-configure
  • ./tools/ipm-performance

You can just copy and paste the license from one of the other tools files into those files. For example:

https://github.com/apache/trafficserver/blob/1c038e512103c4c1b32e335c980f9fae51f45f9d/tools/build_h3_tools.sh#L6-L20


Update

Oh, I see. This patch copies content from Intel. Hmmm...it looks like their copyright is a pretty open, BSD style license? I believe what we may want to do is copy both the Intel copyright and our Apache copyright into this file. @bryancall / @zwoop : do you know what the precedent is for such copies from other source code?

bneradt avatar Apr 26 '22 14:04 bneradt

This has been in draft for a while. Is it ready for review?

moonchen avatar May 16 '22 23:05 moonchen

[approve ci autest]

bryancall avatar Aug 29 '22 23:08 bryancall

[approve ci centos cmake]

ezelkow1 avatar May 19 '23 17:05 ezelkow1

[approve ci]

bryancall avatar Jul 26 '23 21:07 bryancall

@cukiernik is this change relevant since Intel stopped supporting Optane?

bryancall avatar Oct 09 '23 22:10 bryancall

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Jan 08 '24 01:01 github-actions[bot]