trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

MiMalloc nodump allocator

Open duke8253 opened this issue 2 years ago • 5 comments

When building with MiMalloc, create a no dump heap for each thread, which should behave just like the custom no dump arena for jemalloc. Also updated the license of the file since this is now very different from what facebook had (which this was based on when it all started).

It would be great if @bryancall can run some benchmarks like the ones did for #7501.

duke8253 avatar Apr 12 '22 20:04 duke8253

@cmcfarlen will review this

bryancall avatar Apr 18 '22 23:04 bryancall

image

bryancall avatar Aug 24 '22 22:08 bryancall

Here is a link to the spreadsheet: https://docs.google.com/spreadsheets/d/1oyblceruVgDD9-YhKNfRSEP7Vv5ECN9Rj5O-MlZhYIY/edit?usp=sharing Here are the details of the benchmark runs: https://github.com/bryancall/benchmark/tree/main/mimalloc_reports

bryancall avatar Aug 24 '22 22:08 bryancall

Overall there was a 2.17% reduction in throughput with this PR. Some of that could be noise in the benchmark run.

bryancall avatar Aug 24 '22 22:08 bryancall

[approve ci]

duke8253 avatar Aug 29 '22 19:08 duke8253