trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

pcre library needs to be upgrade to pcre2

Open c-taylor opened this issue 2 years ago • 6 comments

Current issues are:

  • pcre library is no longer maintained; author working on pcre2
  • pcre jit support in ATS is incomplete
    • https://issues.apache.org/jira/browse/TS-3143
    • https://issues.apache.org/jira/browse/TS-3144
  • Precompilation is not consistently implemented
  • Library review
    • Should probably look at pcre2/je2 (or others)

Whilst looking at some high RPS rate tests libpcre was starting to 'feature' in traces. The obvious optimisation for libpcre is to use the jit support, which probably lends itself well to constrained lists of regex.

However, given the lack of maintenance on the current library an "architectural review" is probably required before more effort is spent...

c-taylor avatar Apr 05 '22 17:04 c-taylor

It looks like trafficserver has an inconsistent approach: It precompiles the expressions, replacing the need/benefit of the jit in header_rewrite, but elsewhere makes no attempt.

Perhaps someone can confirm…

c-taylor avatar Apr 05 '22 20:04 c-taylor

There is a new Fedora tracking bug for this issue: https://bugzilla.redhat.com/show_bug.cgi?id=2128391

jeredfloyd avatar Sep 20 '22 13:09 jeredfloyd

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Sep 21 '23 01:09 github-actions[bot]

Just to tell the bot this is not stale, we are going to do this by version 10.0 release.

maskit avatar Sep 21 '23 15:09 maskit

On the corresponding Debian bug, there is a patch available.

bgermann avatar Jan 20 '24 18:01 bgermann