trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Published 20 hours ago • verified publisher icon apache

Create Task threads before scheduling tasks

Open vmamidi opened this issue 2 years ago • 9 comments

Tasks are scheduled on NET threads as there are no task threads available when the tasks are scheduled.

vmamidi avatar Mar 03 '22 22:03 vmamidi

[approve ci autest]

vmamidi avatar Mar 06 '22 16:03 vmamidi

These are legit autest failures. At least one of these tests, has a global plugin that attempts to configure logging for itself, but crashes because logging hasn't been initialized yet.

randall avatar Mar 14 '22 22:03 randall

[approve ci]

bryancall avatar Mar 21 '22 23:03 bryancall

[approve ci autest]

duke8253 avatar Jun 28 '22 18:06 duke8253

This could be related to #8920

duke8253 avatar Jun 28 '22 18:06 duke8253

Noticed something interesting. The test is failing because after the change, it no longer runs on a ET_TASK thread, instead it runs on the main thread for some reason.

duke8253 avatar Jun 30 '22 18:06 duke8253

I've got a fix for this autest failure, it also addresses the problem where there callback function being called manually. https://github.com/duke8253/trafficserver/commit/317e65ade30e6ff1b53360d52a2b1aeb1e195f96

duke8253 avatar Jul 06 '22 21:07 duke8253

Hi @vmamidi . Just making sure you saw @duke8253's message above. I've pulled in his fix internally at Yahoo and CI has been happy with it. It should fix things here.

bneradt avatar Jul 11 '22 23:07 bneradt

[approve ci autest]

vmamidi avatar Jul 12 '22 04:07 vmamidi

This is fixed by PR #8981

duke8253 avatar Aug 29 '22 21:08 duke8253

Remember to remove Milestone's and Project's when closing a PR without merging it.

zwoop avatar Aug 29 '22 22:08 zwoop