trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Mutual exclusion problem in mysql_remap plugin

Open klebertarcisio opened this issue 5 years ago • 2 comments

Hi Peeps,

Look this previous discussion in: https://github.com/apache/trafficserver/issues/6627

I am commenting about the malloc of line 188. Is there a need to call the free function? The do_mysql_remap function already has a local query variable. What would be the best solution? Delete the my_data struct? How would it be replaced? The iniparser_freedict method frees several resources. Would it be interesting to release the data as well? Sorry for the amount of questions. I'm trying to understand the big picture.

https://github.com/apache/trafficserver/blob/21f6a702f6874a49efa15336a740d1859f20bb15/plugins/experimental/mysql_remap/mysql_remap.cc#L188

Regards

klebertarcisio avatar Apr 08 '20 16:04 klebertarcisio

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Jun 18 '21 18:06 github-actions[bot]

The plan is the deprecate the plugin for ATS 10.x. Do you use this plugin and do you want to support it?

bryancall avatar Oct 25 '21 23:10 bryancall