trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Published 20 hours ago • verified publisher icon apache

Use large IOBufferBlock only on sending DATA frame

Open masaori335 opened this issue 10 months ago • 7 comments

Prior to the change, when HTTP/2 connection is created, the write_buffer is allocated with http2.write_buffer_block_size (default value is 256KB). However, only DATA frame needs such large buffer.

masaori335 avatar Apr 09 '24 00:04 masaori335

"AuTest 1of4" needs https://github.com/apache/trafficserver/pull/11230

masaori335 avatar Apr 10 '24 06:04 masaori335

"AuTest 1of4" needs #11230

Does the change from this patch make that more likely? I don't recall seeing that issue from the ja3_fingerprint test before.

bneradt avatar Apr 11 '24 21:04 bneradt

Right, I ran the AuTest several times locally, it looks like this change made the flipping the debug order of threads frequently. Allocating 256KB and 4KB might have big difference.

masaori335 avatar Apr 11 '24 23:04 masaori335

The ja_fingerprint test needs #11254 too. It passed 10 times in local docker env.

masaori335 avatar Apr 15 '24 04:04 masaori335

All green, ja_fingerprint fix worked!

masaori335 avatar Apr 16 '24 02:04 masaori335

[approve ci autest]

duke8253 avatar May 01 '24 19:05 duke8253

Rebased on the latest master. Please take another look.

masaori335 avatar May 02 '24 04:05 masaori335

Cherry-picked to v10.0.x

cmcfarlen avatar May 16 '24 11:05 cmcfarlen