TS_ALPN_PROTOCOL_ symbols are defined in the wrong place

[JosiahWI]

A bunch of HTTP/HTTPS protocol constants that are supposed to be part of the public TS API are declared in ts/apidefs.h.in and defined in records/RecHttp.cc. We do not link plugins against the records library, so these symbols may not be visible to the linker as they should be. This is a bug and it just happens to work in master. That's fragile; the evidence is the OSX build breaking on #10967 because of simple CMake changes that should have been safe.

Simply moving the definitions from records to api is not enough by itself, because RecHttp.h depends on a subset of those symbols, particularly the TS_ALPN_PROTOCOL_INDEX_ ones. I've played around with defining one set of constants in RecHttp.h and making the TS_ALPN_PROTOCOL_INDEX variables references to that first set of constants. This works fine, but declaring those variables as references might break API compatibility, so it might not be a usable solution.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.