trafficserver icon indicating copy to clipboard operation
trafficserver copied to clipboard

Return status 500 instead of abort

Open maskit opened this issue 2 years ago • 3 comments

ink_release_assert is used at over 400 places. Although having core files is helpful for debugging, it kills all connections abruptly and it's not nice to clients. It'd be nice if we could just return status 500 and save connections/requests that don't face any issues.

maskit avatar Jul 24 '23 18:07 maskit

ink_release_assert should be used for internal invariants (i.e. when you do something that never fails and you want to document that it never fails). If ink_release_assert ever fails, it ought to be a serious bug.

jpeach avatar Jul 25 '23 03:07 jpeach

Yes I'd use it like that, but some of ink_release_assert are casually used like "I want some hint (coredump) if this check fails".

maskit avatar Jul 25 '23 16:07 maskit

This issue has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

github-actions[bot] avatar Jul 25 '24 01:07 github-actions[bot]