[TC-85] Should use "dest_ip" instead of "dest_domain" in "parent.config" and "cache.config" when ofqdn is ip

[limited]

Should use "dest_ip" instead of "dest_domain" in "parent.config" and "cache.config" when ofqdn is ip.

Author: Jifeng Yang JIRA Link: https://issues.apache.org/jira/browse/TC-85 Found Version: 2.1.0

[dneuman64]

I don't believe this will be included in 2.1, moving to 2.2.

[mitchell852]

@rob05c - do you think this is still relevant w/ atstccfg? how big of a deal is it if we use dest_domain instead of dest_ip? do you know?

[rob05c]

Yeah, it's still relevant. I don't think it's a huge issue, because we always use dest_domain, and MSO will put IPs in there, and it seems to work.

It's still something we should fix, because ATS says it's wrong, so it could theoretically break in the future.

We'll probably change TC config gen to always use Strategies, once we have them in ATS 9/10.

But until then, I'd vote keep this issue open, just to not forget about it.

[rob05c]

Copied from #7021 :

it seems to work.

It doesn't work, that statement is wrong. I think we just didn't realize it before, because it falls back to the default, and we didn't used to have complex custom parents until recently.

This issue didn't capture the complete issue with the bug. This issue said we should do it, it doesn't say why. The reason and bug is that dest_domain=ip is silently ignored by ATS as if the entire line doesn't exist.

MSO will put IPs

This also isn't true. I'm not sure if it was true in the past, but it isn't now. MSO will put the Org Server FQDN in the dest_domain=, and put the true MSO origins in the parent=, which are configurable as IPs or FQDNs and ATS is fine with either. #7021 implicitly fixes MSO IPs to be dest_ip as well, so MSO OrgServerFQDN IPs are also fixed by it.