trafficcontrol
trafficcontrol copied to clipboard
TPv2 Add Download Options Dialog to Generic Table
This PR adds a dialog to the download csv button on the TPv2 generic table. This dialog lets the user change what is downloaded including: filename, delimiter, headers, hidden columns, hidden rows, only selected rows.
Which Traffic Control components are affected by this PR?
- Traffic Portal v2
What is the best way to verify this PR?
Verify tests and lint pass. Go-to any table and confirm the dialog works and options are respected.
PR submission checklist
- [x] This PR has tests
- [ ] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. ->
- [ ] This PR has a CHANGELOG.md entry
- [x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 65.84%. Comparing base (
a6b2954
) to head (86d77ed
). Report is 99 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #7472 +/- ##
============================================
+ Coverage 65.64% 65.84% +0.19%
Complexity 98 98
============================================
Files 323 328 +5
Lines 12827 13042 +215
Branches 965 999 +34
============================================
+ Hits 8420 8587 +167
- Misses 4048 4093 +45
- Partials 359 362 +3
Flag | Coverage Δ | |
---|---|---|
traffic_portal_v2 | 74.52% <100.00%> (+0.12%) |
:arrow_up: |
unit_tests | 74.52% <100.00%> (+0.12%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM
@ntheanh201 To review the PR, go to https://github.com/apache/trafficcontrol/pull/7472/files and either approve the PR or request changes.
Once it is approved, I can merge :)