trafficcontrol icon indicating copy to clipboard operation
trafficcontrol copied to clipboard

Use "twelve" as the password where "twelve12" was used

Open zrhoffman opened this issue 2 years ago • 5 comments

#4764 changed the default password in some places, but not all, from twelve to twelve12. This is confusing for all of the people who are used to twelve being the default password for all components of the project. This PR reverts all instances of twelve12 to twelve.


Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • CDN in a Box for Developers
  • Traffic Portal
  • Traffic Portal v2

What is the best way to verify this PR?

Verify the tests pass

PR submission checklist

zrhoffman avatar Oct 19 '22 18:10 zrhoffman

I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.

ocket8888 avatar Oct 26 '22 16:10 ocket8888

how about using password as the password? that meets the 8 character requirement. this is just used for cdn in a box, right?

mitchell852 avatar Nov 28 '23 22:11 mitchell852

I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.

twelve12 is in invalid_passwords.txt (as is twelve), it would be rejected by the API. But using twelve12 detracts from usability, and keeping twelve does not.

zrhoffman avatar Nov 28 '23 22:11 zrhoffman

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7a3e1e0) 28.96% compared to head (e2ebbce) 65.64%. Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7149       +/-   ##
=============================================
+ Coverage     28.96%   65.64%   +36.68%     
  Complexity       98       98               
=============================================
  Files           602      323      -279     
  Lines         77452    12836    -64616     
  Branches         90      970      +880     
=============================================
- Hits          22432     8426    -14006     
+ Misses        52926     4050    -48876     
+ Partials       2094      360     -1734     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 74.35% <100.00%> (?)
traffic_stats_unit ?
unit_tests 74.35% <100.00%> (+48.55%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 28 '23 22:11 codecov[bot]

If twelve12 would be rejected by the API then it shouldn't be in use either. It does, at least, meet the requirements in TP(v1), but really we should have a password that will be accepted. Like twelve12! (I hope; I didn't check).

ocket8888 avatar Nov 29 '23 05:11 ocket8888