trafficcontrol icon indicating copy to clipboard operation
trafficcontrol copied to clipboard

Traffic Stats for Docker

Open smalenfant opened this issue 4 years ago • 5 comments

What does this PR (Pull Request) do?

  • [ ] This PR fixes #REPLACE_ME OR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Documentation
  • Grove
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Portal
  • Traffic Router
  • Traffic Stats
  • Traffic Vault
  • CI tests

What is the best way to verify this PR?

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • [ ] This PR includes tests OR I have explained why tests are unnecessary
  • [ ] This PR includes documentation OR I have explained why documentation is unnecessary
  • [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • [ ] This PR includes any and all required license headers
  • [ ] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

smalenfant avatar Jan 13 '21 19:01 smalenfant

We already have a (pre-CDN in a Box) attempt at a Docker environment for Apache Traffic Control at https://github.com/apache/trafficcontrol/tree/c29dba212d/infrastructure/docker (see: all subdirectories except for build).

~All~ Some of them are pretty outdated, but if you're building a Docker environment for Traffic Stats, maybe you can replace the old Traffic Stats Docker image.

zrhoffman avatar Jan 13 '21 19:01 zrhoffman

+1 for infrastructure/docker

Some of them are outdated, there aren't many people using them. I don't use Traffic Stats much. But I use the DB+TO+TP+TV almost daily. Just because they're faster than the CiaB, and more persistent.

I think updating or replacing infrastructure/docker/traffic_stats is the right answer here.

rob05c avatar Jan 13 '21 19:01 rob05c

I think I'm trying to do something a little different. This runs grafana + influxdb + traffic_stats. Traffic Stats should be it's own component. If somebody needs to run InfluxDB and Grafana, that should be separate (use docker-compose).

I'm also trying not to depend on the RPM build. It's just too many steps that are not needed. That's why the Dockerfile is in the "traffic_monitor" directory. I'm open to suggestions but really I want to be able to use apache/traffic_stats:$RELEASE from docker hub.

smalenfant avatar Jan 13 '21 20:01 smalenfant

Ah, that makes sense. So yeah, it should be its own thing.

I'd vote we be pretty open about accepting things like this. If Docker Hub is what you need, sure, we can add that. We can always remove it later if nobody is using it.

I'd still lean toward putting Docker stuff in /infrastructure

rob05c avatar Jan 13 '21 20:01 rob05c

I'm also trying not to depend on the RPM build. It's just too many steps that are not needed.

I been saying that for years, godspeed.

We might use your work in a project some of us were thinking of doing: CiaB but only for development. Which is specifically where we wouldn't want to bother building RPMs.

ocket8888 avatar Jan 13 '21 20:01 ocket8888