TP/TO: Queuing Servers for updates - Queues up all the servers

[lbathina]

I'm submitting a ...

• [ ] bug report
• [ ] new feature / enhancement request
• [x] improvement request (usability, performance, tech debt, etc.)
• [ ] other

Traffic Control components affected ...

• [ ] CDN in a Box
• [ ] Documentation
• [ ] Grove
• [ ] Traffic Control Client
• [ ] Traffic Monitor
• [x] Traffic Ops
• [ ] Traffic Ops ORT
• [X] Traffic Portal
• [ ] Traffic Router
• [ ] Traffic Stats
• [ ] Traffic Vault
• [ ] unknown

Current behavior:

When Queue Server Updates is performed All the servers other than edges and mids get the wait icon next to it.

Expected / new behavior:

Only Mids and Edges should be queued for updates and the wait/pending icon should be displayed next to only edge and mid servers

Minimal reproduction of the problem with instructions:

Anything else:

[ocket8888]

What do you mean by "Queue Server Updates"? There are a few different ways to do that. What exactly did you do?

[mitchell852]

What do you mean by "Queue Server Updates"? There are a few different ways to do that. What exactly did you do?

She queued server updates at the cdn level which will queue ALL servers in the CDN even though only Edges / Mids are affected by a "queue". This won't hurt anything but it is kind of silly to set the upd_pending flag = true on anything besides an Edge* / Mid*

IMO, 2 things should be fixed:

• POST api/1.4/cdns/2/queue_update should only update Edge* / Mid* servers
• In TP, the "updates pending" column of the servers table should probably be N/A if the server is not Edge* / Mid*
• In TP, the server create/update form should only have a Update Pending field if it's an Edge* / Mid*

[ocket8888]

I think other server types can meaningfully have pending updates, although I can't quite remember for sure.

[mitchell852]

I think other server types can meaningfully have pending updates, although I can't quite remember for sure.

hmmm. i don't think so...but i guess i'm not 100% sure...I always think of "queue updates" as meaning "queue ats config file updates" which would imply only things running ATS (edges or mids)