tomee icon indicating copy to clipboard operation
tomee copied to clipboard

Published 20 hours ago • verified publisher icon apache

[TOMEE-4061] Derby 10.15.2.0

Open sultan opened this issue 2 years ago • 1 comments

This i a tentative to update Derby to 10.15.x, upon other dep updates.

Derby 10.15.x is modular, it might break CI, please merge wisely.

sultan avatar Oct 06 '22 08:10 sultan

CI build ok on my fork https://github.com/sultan/tomee/actions/runs/3195891350/jobs/5217111532

sultan avatar Oct 06 '22 09:10 sultan

rebased upon:

  • PR #938

sultan avatar Oct 23 '22 10:10 sultan

@sultan Can you rebase this one? So we can create a CI task for it to see

rzo1 avatar Oct 24 '22 10:10 rzo1

on it.

sultan avatar Oct 24 '22 10:10 sultan

@rzo1, rebased and ready for CI test

sultan avatar Oct 24 '22 11:10 sultan

Thanks. I created a CI task for it: https://ci-builds.apache.org/job/Tomee/job/TOMEE-4061/

rzo1 avatar Oct 24 '22 11:10 rzo1

@sultan looks like two regressions:

org.apache.openejb.arquillian.EarWarResourcesXmlTest.(?)

org.apache.openejb.resource.jdbc.driver.AlternateDriverJarTest.testBoth

Might be quick ones: class not found and missing jar.

rzo1 avatar Oct 24 '22 16:10 rzo1

ok i'll see if i can correct

sultan avatar Oct 24 '22 16:10 sultan

If you need help/support, just drop a message in the list or in the PR.

rzo1 avatar Oct 24 '22 16:10 rzo1

@jeanouii updated this test last year for it to pass, i hard coded the test so that the 'two drivers' are 10.10 and 10.14. you both might want to review this change.

sultan avatar Oct 24 '22 17:10 sultan

TO BE MERGED AFTER:

  • PR #938
  • PR #953

sultan avatar Nov 08 '22 12:11 sultan

rebased upon dependencies cleanup, i do recommend:

no more job on my side, and ready

sultan avatar Nov 09 '22 14:11 sultan

TODO :

  • create a JIRA for this dep update

sultan avatar Nov 09 '22 15:11 sultan

rebased upon tomee-9.x

please review

sultan avatar Jan 04 '23 14:01 sultan

is this PR still needed ?

sultan avatar Jan 20 '23 16:01 sultan

Only derby left. I triggered a full build for it.

rzo1 avatar Jan 26 '23 10:01 rzo1

I think, that we need to port these changes targeting https://github.com/apache/tomee/pull/1005 as well.

rzo1 avatar Feb 07 '23 07:02 rzo1

I'm ok to merge this one too. But this is with the view that we may need to revert because of the TCK setup. I remember TCK issues but probably a good time to address those as well. Thanks @sultan

jeanouii avatar Feb 07 '23 10:02 jeanouii

I'm ok to merge this one too. But this is with the view that we may need to revert because of the TCK setup. I remember TCK issues but probably a good time to address those as well. Thanks @sultan

this will be in PR #1021 ... its a small PR so no problem reverting it if needed

sultan avatar Feb 07 '23 12:02 sultan