tomcat-native icon indicating copy to clipboard operation
tomcat-native copied to clipboard

Simplify Address#getInfo() native implementation

Open michael-o opened this issue 4 years ago • 7 comments
trafficstars

Don't apply tricks and rely on OS behavior to resolve addresses. This also aligns with the NIO implementatin using InetSocketAddress.

This mimics the behavior of HTTPd's listen.c for apr_sockaddr_info_get().

@mturk Let's discuss. I'd like to understand what will break in your deployments.

michael-o avatar May 26 '21 09:05 michael-o

This changes behaviour so it would need to wait until 1.3 (if there ever is such a version). Note that the current plan is that the code being discussed here would be removed in 2.0.

markt-asf avatar May 27 '21 15:05 markt-asf

This changes behaviour so it would need to wait until 1.3 (if there ever is such a version). Note that the current plan is that the code being discussed here would be removed in 2.0.

For a transition phase, I would favor to remove everything in 1.3 which isn't used by Tomcat at all. In 2.0 remove APR. 1.3 can contain cleanups like this.

OR do 2.0 and then 3.0 which support OpenSSL 1.1.1 and 3.0.0.

michael-o avatar May 27 '21 16:05 michael-o

@mturk You still owe me an explanation what will break for you.

michael-o avatar Jun 07 '21 17:06 michael-o

@mturk Still waiting...

michael-o avatar Aug 12 '21 08:08 michael-o

@mturk Still waiting...

michael-o avatar Dec 22 '21 09:12 michael-o

@mturk still waiting...

michael-o avatar Aug 14 '22 18:08 michael-o

@mturk still waiting for years...

michael-o avatar Sep 26 '23 14:09 michael-o