tomcat-maven-plugin icon indicating copy to clipboard operation
tomcat-maven-plugin copied to clipboard

Handle failed tomcat war deployment (status OK but body FAIL)

Open laurentperez opened this issue 7 years ago • 4 comments

per http://tomcat.apache.org/tomcat-7.0-doc/manager-howto.html a failed deploy will trigger a body with status code 200 but with body response starting with FAIL (i18n)

this patch adds the FAIL body response handler for en/fr languages

unsure if tests are really needed (?)

laurentperez avatar May 24 '17 10:05 laurentperez

@michael-o do you think I should add tests ? this is a basic feat. thx for the review

laurentperez avatar May 24 '17 19:05 laurentperez

Absolutely, if you think you can! Don't forget to squash your commits!

michael-o avatar May 24 '17 20:05 michael-o

@olamy @michael-o Are there any plans to release new version of this plugin?

aleksandr-m avatar Jun 19 '18 16:06 aleksandr-m

Wow, I completely forgot this. Will have a look later.

michael-o avatar Jun 19 '18 18:06 michael-o