apache
Add String IdManager
Add an IdManager that creates stringified UUIDs and accepts any non-empty string
Codecov Report
Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
Project coverage is 76.73%. Comparing base (
9b46b67) to head (234955f). Report is 203 commits behind head on 3.7-dev.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...lin/tinkergraph/structure/AbstractTinkerGraph.java | 40.00% | 4 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 3.7-dev #2743 +/- ##
=============================================
+ Coverage 76.14% 76.73% +0.59%
- Complexity 13152 13203 +51
=============================================
Files 1084 1087 +3
Lines 65160 66436 +1276
Branches 7285 7312 +27
=============================================
+ Hits 49616 50981 +1365
+ Misses 12839 12741 -98
- Partials 2705 2714 +9
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
VOTE +1. Thanks @danielcweber! I will go ahead and resolve the minor changelog conflict and merge this.
Actually I just realized, we might still need some actions from your side @danielcweber, I see your base branch is on 3.7-dev but this PR is against master, which will be for future 4.0 release.
Did you intent for this change to go into master? If so, you can rebase your branch to master. I also don't have any particular concerns with this going into 3.7 either. Let me know your thoughts or if you have any questions around this. Thanks!
It was meant to be on 3.7 which I usually am aware of...will rebase in a minute
It was based on 3.7 already but became conflicted. Rebased it and changed the base branch in Github.
I had a look into the failing checks but they seem unrelated
They do look unrelated so I just restarted the failing actions. I'll merge the PR today then. Thanks Daniel!