tika icon indicating copy to clipboard operation
tika copied to clipboard
verified publisher icon apache

TIKA-1997 -- initial poc, derived from rob975's work on: https://github.com/apache/tika/pull/267

Open tballison opened this issue 6 months ago • 3 comments

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

tballison avatar Jul 14 '25 19:07 tballison

After 6 years without feedback I dropped the fork, hence closing the PR. Hope your PR gets merged. The tests commented out rely on content inspection like it used to be done for XML files. Idk if it can still be done.

rob975 avatar Jul 16 '25 15:07 rob975

This is referenced in https://issues.apache.org/jira/browse/TIKA-3784 (years long discussion). That's how I found here. What are the reasons for this to be labeled as draft?

marcelstoer avatar Oct 21 '25 06:10 marcelstoer

Life got in the way. :rofl:

Other key issue is that I'm not sure I'm doing the right thing to differentiate the different subtypes after I have the asn1 objects.

@marcelstoer if my hackery looks good to you, we can merge this in main and 3.x.

Does everything in handleRootNode make sense: https://github.com/apache/tika/pull/2281/files#diff-5a26b8c1832969c3c4b279df1fa66811d46a57da6589767ee4bb584de1fa84faR120

tballison avatar Oct 21 '25 12:10 tballison