tika icon indicating copy to clipboard operation
tika copied to clipboard

add errorprone back in

Open tballison opened this issue 7 months ago • 1 comments

When we run javadoc:aggregate, this dependency is needed. Would it cause problems if we added it? Do we need to exclude it from the other grpc dependencies where we're currently excluding it?

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

tballison avatar May 29 '25 20:05 tballison

@nddipiazza , I'm hesitant to merge this because of all the exclusions in the grpc pom for this artifact. We need it for javadoc-aggregate. Does it hurt grpc to include it?

There's no rush on this...sometime before we have to generate javadocs again. LOL...

Thank you!

tballison avatar Jun 03 '25 13:06 tballison

@nddipiazza I needed this for javadocs. Please undo if I'm breaking anything in grpc.

tballison avatar Oct 02 '25 19:10 tballison