tika icon indicating copy to clipboard operation
tika copied to clipboard

TikaFix ---Contribution by jerni-zu393

Open jerni-zu393 opened this issue 7 years ago • 3 comments

I have added the magic bits for three files (*.keystore/.jks , *.apk , *.aac). It can be detect the file types even the files should not have "."extensions .

I have attached here below the sample files for testing purpose .

keystore.tar.gz

apktest.zip aactest.zip

jerni-zu393 avatar Jun 15 '17 09:06 jerni-zu393

Any updates ?

jerni-zu393 avatar Jul 03 '17 08:07 jerni-zu393

@Gagravarr any objections? Would be useful to open a ticket on our JIRA to track to this. Also would be helpful to add unit tests with files that you've provided. Thank you!

tballison avatar Jul 03 '17 11:07 tballison

The keystore one should probably go further down the file, so it's in alphabetical order as the others are

For APC files, do we know if they always store the entries in that specific order? Or if it might change? Currently ZipContainerDetector only requires AndroidManifest.xml to be present, do we want to mirror that or keep your wider list of files required?

The AAC file magic with ID3 at the front doesn't necessarily look right to me - won't most MP3 files with ID3 tags in first incorrectly match on this too?

Gagravarr avatar Jul 03 '17 14:07 Gagravarr