thrift
thrift copied to clipboard
apache
THRIFT-5712 - Added Dart 3 Compatibility
Since the pullrequest https://github.com/apache/thrift/pull/2930 got stuck, i started over fresh and implemented it myself.
- [x] Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
Since there was already an issue (https://issues.apache.org/jira/browse/THRIFT-5712) i commented there.
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? The generated classes now also expose optional values, so for that a customization will be necessary. But this is a new language feature so there is no way around.
- [x] If your change does not involve any code, include
[skip ci]anywhere in the commit message to free up build resources.
First, thanks for the contribution - much appreciated! I made a few comments for things that I foiund during rather quick review.
Since it is a large changeset, I would love a second opinion form someone like @mark-erickson
Sure. I am happy to help. Any suggestions for improvement are always welcome