thrift icon indicating copy to clipboard operation
thrift copied to clipboard

Updated Java keys for cross-platform tests and removed them from known failures

Open kpumuk opened this issue 1 month ago • 1 comments

The truststore and keystore were regenerated using keys in test/keys:

# keytool does not support "replace" operation:
keytool -delete \
    -alias localhost \
    -keystore lib/java/src/crossTest/resources/.truststore \
    -storepass thrift
keytool -import \
    -alias localhost \
    -file test/keys/CA.pem \
    -keystore lib/java/src/crossTest/resources/.truststore \
    -storepass thrift

# server keystore
keytool -importkeystore \
    -srckeystore test/keys/server.p12 \
    -srcstoretype PKCS12 \
    -srcstorepass thrift \
    -destkeystore lib/java/src/crossTest/resources/.serverkeystore \
    -deststoretype pkcs12 \
    -deststorepass thrift

# client keystore
keytool -importkeystore \
    -srckeystore test/keys/client.p12 \
    -srcstoretype PKCS12 \
    -srcstorepass thrift \
    -destkeystore lib/java/src/crossTest/resources/.clientkeystore \
    -deststoretype pkcs12 \
    -deststorepass thrift

Java tests were updated to use separate keystores for client and server.

More discussion in the original commit from @Jens-G that introduces new keys: https://github.com/apache/thrift/commit/b18964e1352bf0e051f6a3d3b8a34e5f34b42543

Also reverts https://github.com/apache/thrift/pull/3237

  • [ ] Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x] Did you squash your changes to a single commit? (not required, but preferred)
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

kpumuk avatar Nov 23 '25 18:11 kpumuk

Build passes here: https://github.com/kpumuk/thrift/actions/runs/19615337502

CleanShot 2025-11-23 at 13 30 21@2x

kpumuk avatar Nov 23 '25 18:11 kpumuk

Failures look like some kind of race condition on CI...

kpumuk avatar Dec 14 '25 22:12 kpumuk

breaks appveyor?

Jens-G avatar Dec 14 '25 23:12 Jens-G

Fetching repository commit (ea3d8b3)...Cannot download GitHub repository contents: NotFound

Something is not right, maybe because I rebased to pick up the fix for Go from the last week? Rebased again with the latest commit, let's see if that fixes this weird "missing commit" issue.

kpumuk avatar Dec 14 '25 23:12 kpumuk