thrift icon indicating copy to clipboard operation
thrift copied to clipboard
verified publisher icon apache

THRIFT-5855: Add netstd fuzzers

Open mhlakhani opened this issue 4 months ago • 6 comments

Experimental RFC for netstd fuzzers. Requesting review for this one as I'm not sure if this is idiomatic C#, or how to build these projects.

I'm worried about bitrot here. Makefile inclusion will hopefully ensure these build in CI and we don't bitrot the build, but if no one's running these fuzzers regularly (due to lack of oss-fuzz support) I'm not sure how impactful these will be.

  • [x] Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x] Did you squash your changes to a single commit? (not required, but preferred)
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

mhlakhani avatar Aug 25 '25 23:08 mhlakhani

I checked twice that I installed sharpfuzz according to the docs but I always get

Build succeeded in 1.2s
Instrumenting assemblies for fuzzing ...
Skipping Thrift.FuzzTests.CompactRoundtripAFL.dll
Skipping Thrift.FuzzTests.BinaryParseLibfuzzer.dll
Instrumenting Microsoft.Extensions.Logging.dll
./buildfuzzers.sh: line 121: sharpfuzz: command not found

I used the docker jammy build environment, if that is relevant.

Jens-G avatar Sep 08 '25 20:09 Jens-G

Ping?

Jens-G avatar Sep 15 '25 19:09 Jens-G

see also #3235

Jens-G avatar Nov 14 '25 09:11 Jens-G

ah, sorry for the delay here, life got in the way - I'll make a pass this weekend

mhlakhani avatar Nov 15 '25 05:11 mhlakhani

it looks like after the move to .net 10, this may not be possible, as sharpfuzz doesn't seem to support it. I'll have to do some more research (I'm not a .NET expert unfortunately)

mhlakhani avatar Nov 23 '25 20:11 mhlakhani

Well, net10 was released only few weeks ago. They might need some time. Since it is the current LTS I would expect it will be supported soon.

Jens-G avatar Nov 25 '25 21:11 Jens-G

Converted to draft. Please make it a PR again (via "ready to review") if you completed it.

Jens-G avatar Dec 14 '25 22:12 Jens-G