thrift icon indicating copy to clipboard operation
thrift copied to clipboard

THRIFT-5877: Add cpp cross tests

Open CJCombrink opened this issue 6 months ago • 1 comments

Add cross tests to the GitHub pipeline builds

During the work two other issues were identified and implemented/fixed: Missing UUID support for THeaderProtocol and TProtocolTap. This PR includes the fixes for both.

Updated the cross tests to include cpp. Also updated the known_issues list by adding all java<->cpp ssl related tests

The tests also identified an issue due to https://github.com/apache/thrift/pull/3165 and should be fixed as well

  • [x] Did you create an Apache Jira ticket?
  • [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [ ] Did you squash your changes to a single commit? (not required, but preferred)
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

CJCombrink avatar Jun 12 '25 19:06 CJCombrink

Looks like something was broken in this PR: https://github.com/apache/thrift/pull/3165

CJCombrink avatar Jun 12 '25 19:06 CJCombrink

@Jens-G Can this PR please get workflow approval for this PR

@fishy Would you please be so kind to give this PR a once over. it is almost a duplicate of the PR that you have approved before but I made a new cleaned up PR trying to be on topic

CJCombrink avatar Jun 19 '25 11:06 CJCombrink

Can this PR please get workflow approval for this PR

Done, didn't see this earlier

Jens-G avatar Jul 05 '25 08:07 Jens-G

If I read correctly the PR#3179 should get the cpp-rs tests to also pass. @Jens-G can you re-look at this PR please

CJCombrink avatar Jul 21 '25 06:07 CJCombrink

@Jens-G Is there anything holding this PR back, perhaps some refactoring or moving things around that should be done to get this merged?

CJCombrink avatar Aug 01 '25 05:08 CJCombrink

@CJCombrink can you please squash your commits? I can merge this after that.

fishy avatar Aug 01 '25 16:08 fishy

@Jens-G @fishy

Thanks, I have squashed and rebased, if the build pass it should be ready to merge

CJCombrink avatar Aug 02 '25 07:08 CJCombrink