thrift icon indicating copy to clipboard operation
thrift copied to clipboard

enforce to close accepted connection after processing

Open jshen14 opened this issue 2 years ago • 3 comments

Enforce close of accepted connection in golang simple server to avoid memory leak

  • [ ] Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x] Did you squash your changes to a single commit? (not required, but preferred)
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

jshen14 avatar Nov 17 '23 22:11 jshen14

please fix the failed unit test.

fishy avatar Nov 21 '23 18:11 fishy

@fishy I updated to fix golang unit test. Now I see there is build error due to python test. I dont understand how that is related to my changes. Could you help me understand what I need to fix?

jshen14 avatar Nov 24 '23 18:11 jshen14

@jshen14 sorry I missed your comment last year 😓

please rebase your change on top of latest master branch and the python tests should be fixed now.

fishy avatar Jul 10 '24 21:07 fishy