thrift icon indicating copy to clipboard operation
thrift copied to clipboard

Fix: fix python readMessageBegin return value type error

Open bwangelme opened this issue 1 year ago • 3 comments

What did this PR do?

In the function transport.TTransport.readAll, when the sz<0, the type of name is str.

But when the sz>0, the type of name is bytes.

They should return the same types.

I use the binary_to_str to convert the type of name

Test

I write a unittest method test_TBinaryProtocol_no_strict_write_read to test my changes. It passed.

  • [ ] Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x] Did you squash your changes to a single commit? (not required, but preferred)
  • [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [x] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

bwangelme avatar Nov 06 '23 04:11 bwangelme

It is not a trivial change, so I didn't create an Apache Jira ticket.

Sorry but that gives no meaning.

Jens-G avatar Nov 06 '23 20:11 Jens-G

Sorry but that gives no meaning.

Ok, Delete it from the description.​

bwangelme avatar Nov 07 '23 10:11 bwangelme

  • cross-test (java, go,rs) (pull_request)
  • cross-test (kotlin, go,rs) (pull_request)
  • cross-test (go, java,kotlin) (pull_request)
  • cross-test (rs, java,kotlin) (pull_request)
  • cross-test (rs, swift) (pull_request)
  • cross-test (rs, go,rs) (pull_request)
  • cross-test (swift, go,rs) (pull_request)

These ci are failed. It seems unrelated to my python changes.

bwangelme avatar Nov 08 '23 04:11 bwangelme