thrift icon indicating copy to clipboard operation
thrift copied to clipboard

ruby: fix failing tests with Ruby 3.0

Open stanhu opened this issue 3 years ago • 2 comments

The tests were previously failing due to keyword argument changes in Ruby 3.0.

  • [ ] Did you create an Apache Jira ticket? (not required for trivial changes)
  • [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [x] Did you squash your changes to a single commit? (not required, but preferred)
  • [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [ ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

stanhu avatar Nov 28 '22 19:11 stanhu

Thanks!

There are some more errors, possible to fix these as well?

Primarily this one:

TypeError: can't convert SpecServerSocket to IO (SpecServerSocket#to_io gives NilClass)

but there's also some more warnings.

Jens-G avatar Nov 30 '22 21:11 Jens-G

Thanks!

There are some more errors, possible to fix these as well?

Primarily this one:

TypeError: can't convert SpecServerSocket to IO (SpecServerSocket#to_io gives NilClass)

but there's also some more warnings.

I think that warning is from Ruby 2.5. I'm not seeing this test failure in Ruby 2.7.5 or 3.0.5.

stanhu avatar Nov 30 '22 21:11 stanhu