thrift icon indicating copy to clipboard operation
thrift copied to clipboard

THRIFT-5559: Make handler public in Rust codegen

Open fayalalebrun opened this issue 2 years ago • 2 comments

Previously it was not possible to access the handler object after it was passed to the service processor. This practically prevents the use of any state which is not wrapped by a reference counted pointer. Especially in single-threaded scenarios, this may be undesirable.

  • [ x ] Did you create an Apache Jira ticket? (not required for trivial changes)
  • [ x ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • [ x ] Did you squash your changes to a single commit? (not required, but preferred)
  • [ x ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • [ x ] If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

fayalalebrun avatar Apr 23 '22 13:04 fayalalebrun

[puzzled] I thought I'd merged this a while back?

allengeorge avatar Jul 01 '22 15:07 allengeorge

As far as I know, this change has not been merged.

fayalalebrun avatar Jul 01 '22 18:07 fayalalebrun