tez
tez copied to clipboard
apache
Fixed string comparison in TezSplitGrouper - need to use equals()
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 26m 27s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 11m 27s | master passed |
| +1 :green_heart: | compile | 0m 33s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | compile | 0m 29s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | checkstyle | 0m 57s | master passed |
| +1 :green_heart: | javadoc | 0m 39s | master passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 28s | master passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +0 :ok: | spotbugs | 1m 9s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 6s | master passed |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 0m 19s | the patch passed |
| +1 :green_heart: | compile | 0m 19s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javac | 0m 19s | the patch passed |
| +1 :green_heart: | compile | 0m 18s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | javac | 0m 18s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 11s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 16s | the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 14s | the patch passed with JDK Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| +1 :green_heart: | findbugs | 0m 43s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 1m 24s | tez-mapreduce in the patch passed. |
| +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. |
| 47m 9s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-401/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/401 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux b68b66e3c1f7 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 7c24f25ed |
| Default Java | Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06~us1-0ubuntu1~22.04-b06 |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-401/1/testReport/ |
| Max. process+thread count | 225 (vs. ulimit of 5500) |
| modules | C: tez-mapreduce U: tez-mapreduce |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-401/1/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
emptyLocations is a special string and the design is that object comparison is sufficient here. @dk2k is there a case or test you can write that shows object comparison isn't sufficient?
