tez icon indicating copy to clipboard operation
tez copied to clipboard

Published 20 hours ago • verified publisher icon apache

[TEZ-4019] Modify Tez shuffle handler to use AuxiliaryLocalPathHandler instead of LocalDirAllocator

Open jteagles opened this issue 9 months ago • 3 comments

jteagles avatar May 09 '24 22:05 jteagles

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 14m 12s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 13m 20s master passed
+1 :green_heart: compile 0m 20s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 0m 19s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 1m 5s master passed
+1 :green_heart: javadoc 0m 28s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 17s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 0m 59s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 18s the patch passed
+1 :green_heart: compile 0m 11s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 0m 11s the patch passed
+1 :green_heart: compile 0m 10s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 0m 10s the patch passed
+1 :green_heart: checkstyle 0m 6s tez-plugins/tez-aux-services: The patch generated 0 new + 36 unchanged - 1 fixed = 36 total (was 37)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 7s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 7s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 0m 25s the patch passed
_ Other Tests _
-1 :x: unit 17m 29s tez-aux-services in the patch failed.
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
50m 49s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/355
JIRA Issue TEZ-4019
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux e8eedce6136b 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 7a9211e4d
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/1/artifact/out/patch-unit-tez-plugins_tez-aux-services.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/1/testReport/
Max. process+thread count 1513 (vs. ulimit of 5500)
modules C: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/1/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar May 09 '24 22:05 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 8s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 :green_heart: mvninstall 13m 48s master passed
+1 :green_heart: compile 0m 22s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 0m 18s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 1m 11s master passed
+1 :green_heart: javadoc 0m 27s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 17s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 1s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 1s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 18s the patch passed
+1 :green_heart: compile 0m 11s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 0m 11s the patch passed
+1 :green_heart: compile 0m 9s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 0m 9s the patch passed
-0 :warning: checkstyle 0m 7s tez-plugins/tez-aux-services: The patch generated 3 new + 65 unchanged - 1 fixed = 68 total (was 66)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 6s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 7s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 0m 27s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 38s tez-aux-services in the patch passed.
+1 :green_heart: asflicense 0m 15s The patch does not generate ASF License warnings.
22m 32s
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/355
JIRA Issue TEZ-4019
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 81cbceec1872 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 9a6757b45
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/2/artifact/out/diff-checkstyle-tez-plugins_tez-aux-services.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/2/testReport/
Max. process+thread count 1528 (vs. ulimit of 5500)
modules C: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/2/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar May 10 '24 22:05 tez-yetus

@abstractdog , do you know who might be good to review this ShuffleHandler change? Handles cases where drives go bad or are added back after being fixed

jteagles avatar May 11 '24 00:05 jteagles

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 30m 35s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 :green_heart: mvninstall 19m 0s master passed
+1 :green_heart: compile 0m 29s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 0m 27s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: checkstyle 1m 30s master passed
+1 :green_heart: javadoc 0m 35s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 21s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+0 :ok: spotbugs 1m 16s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 14s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 29s the patch passed
+1 :green_heart: compile 0m 18s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 0m 18s the patch passed
+1 :green_heart: compile 0m 16s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 0m 16s the patch passed
+1 :green_heart: checkstyle 0m 9s tez-plugins/tez-aux-services: The patch generated 0 new + 65 unchanged - 1 fixed = 65 total (was 66)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 9s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 0m 9s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: findbugs 0m 36s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 55s tez-aux-services in the patch passed.
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
60m 29s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/355
JIRA Issue TEZ-4019
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 49defce6224b 5.15.0-94-generic #104-Ubuntu SMP Tue Jan 9 15:25:40 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 9a6757b45
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/3/testReport/
Max. process+thread count 1498 (vs. ulimit of 5500)
modules C: tez-plugins/tez-aux-services U: tez-plugins/tez-aux-services
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-355/3/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar May 13 '24 15:05 tez-yetus

Checkstyle issues have been addressed.

jteagles avatar May 13 '24 15:05 jteagles

@abstractdog , do you know who might be good to review this ShuffleHandler change? Handles cases where drives go bad or are added back after being fixed

thanks for this patch @jteagles! basically I'm fine to switch from LocalDirAllocator to AuxiliaryLocalPathHandler, by looking at YARN-7244 I feel that AuxiliaryLocalPathHandler is kind of the successor of the LocalDirAllocator

what's the default used in hadoop nowadays?

abstractdog avatar May 13 '24 19:05 abstractdog

@abstractdog , do you know who might be good to review this ShuffleHandler change? Handles cases where drives go bad or are added back after being fixed

thanks for this patch @jteagles! basically I'm fine to switch from LocalDirAllocator to AuxiliaryLocalPathHandler, by looking at YARN-7244 I feel that AuxiliaryLocalPathHandler is kind of the successor of the LocalDirAllocator

what's the default used in hadoop nowadays?

AuxiliaryLocalPathHandler is the default for some time in Hadoop and it gives MapReduce shuffle handler the same insight into the disk that the node manager has, meaning the shuffle handler will have the same view of disks as the jobs launched

jteagles avatar May 13 '24 20:05 jteagles