tez icon indicating copy to clipboard operation
tez copied to clipboard

TEZ-4550. Upgrade commons-cli to 1.6.0.

Open slfan1989 opened this issue 1 year ago • 4 comments

JIRA: TEZ-4550. Upgrade commons-cli to 1.6.0.

slfan1989 avatar Apr 03 '24 23:04 slfan1989

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 22m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 14m 7s master passed
+1 :green_heart: compile 2m 19s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 2m 7s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javadoc 1m 50s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 12s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 15s the patch passed
+1 :green_heart: compile 2m 18s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 2m 18s the patch passed
+1 :green_heart: compile 2m 8s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 2m 8s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 2s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 1m 21s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 12s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 :x: unit 49m 30s root in the patch failed.
+1 :green_heart: asflicense 0m 36s The patch does not generate ASF License warnings.
106m 40s
Reason Tests
Failed junit tests tez.test.TestAMRecovery
tez.test.TestRecovery
tez.test.TestDAGRecovery
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/343
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 88cb281869f2 5.15.0-91-generic #101-Ubuntu SMP Tue Nov 14 13:30:08 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / f080031f5
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/testReport/
Max. process+thread count 1309 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/1/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Apr 04 '24 00:04 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 13s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 15m 59s master passed
+1 :green_heart: compile 2m 26s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: compile 2m 7s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javadoc 1m 45s master passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 13s master passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 19s the patch passed
+1 :green_heart: compile 2m 17s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javac 2m 17s the patch passed
+1 :green_heart: compile 2m 10s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
+1 :green_heart: javac 2m 10s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 2s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1
+1 :green_heart: javadoc 1m 12s the patch passed with JDK Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
_ Other Tests _
-1 :x: unit 50m 28s root in the patch failed.
+1 :green_heart: asflicense 0m 41s The patch does not generate ASF License warnings.
87m 22s
Reason Tests
Failed junit tests tez.test.TestAMRecovery
tez.test.TestRecovery
tez.test.TestDAGRecovery
tez.test.TestTezJobs
Subsystem Report/Notes
Docker ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/343
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux a2777bec9310 5.15.0-101-generic #111-Ubuntu SMP Tue Mar 5 20:16:58 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 906059adb
Default Java Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.22+7-post-Ubuntu-0ubuntu222.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_402-8u402-ga-2ubuntu1~22.04-b06
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/2/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar May 05 '24 04:05 tez-yetus

@slfan1989 : can you please check if TestTezJobs failures are related? the rest is TEZ-4559

abstractdog avatar May 06 '24 07:05 abstractdog

@slfan1989 : can you please check if TestTezJobs failures are related? the rest is TEZ-4559

Thank you for the review! I will follow up and check the reasons for the failure of TestTezJobs.

slfan1989 avatar May 07 '24 00:05 slfan1989

tez release 0.10.4 is very soon to be started, shall we postpone this to the next release?

abstractdog avatar Aug 04 '24 06:08 abstractdog

tez release 0.10.4 is very soon to be started, shall we postpone this to the next release?

I will continue to improve this pull request.

slfan1989 avatar Aug 06 '24 00:08 slfan1989

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 22m 18s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 17m 45s master passed
+1 :green_heart: compile 2m 21s master passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 :green_heart: compile 2m 14s master passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
+1 :green_heart: javadoc 1m 44s master passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 :green_heart: javadoc 1m 13s master passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
-0 :warning: patch 25m 50s Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
_ Patch Compile Tests _
+1 :green_heart: mvninstall 4m 32s the patch passed
+1 :green_heart: compile 2m 22s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 :green_heart: javac 2m 22s the patch passed
+1 :green_heart: compile 2m 13s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
+1 :green_heart: javac 2m 13s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 2s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 1m 12s the patch passed with JDK Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04
+1 :green_heart: javadoc 1m 11s the patch passed with JDK Private Build-1.8.0_422-8u422-b05-1~22.04-b05
_ Other Tests _
+1 :green_heart: unit 81m 36s root in the patch passed.
+1 :green_heart: asflicense 0m 41s The patch does not generate ASF License warnings.
142m 38s
Subsystem Report/Notes
Docker ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/343
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux ac1be36a4893 5.15.0-113-generic #123-Ubuntu SMP Mon Jun 10 08:16:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 563b4947b
Default Java Private Build-1.8.0_422-8u422-b05-1~22.04-b05
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.24+8-post-Ubuntu-1ubuntu322.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_422-8u422-b05-1~22.04-b05
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/3/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-343/3/console
versions git=2.34.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Aug 09 '24 07:08 tez-yetus

@abstractdog Can you help review this pr again? Thank you very much!

slfan1989 avatar Aug 09 '24 09:08 slfan1989

@abstractdog Thanks for the review!

slfan1989 avatar Aug 10 '24 02:08 slfan1989