tez
tez copied to clipboard
apache
TEZ-4503: Warn about large conf properties in payload
The changes were tested by running mvn test -Dtest=TestTezUtils and manually inspecting the output under: tez-common/target/surefire-reports/org.apache.tez.common.TestTezUtils-output.txt .
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/home/stamatis/.m2/repository/org/slf4j/slf4j-reload4j/1.7.36/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/home/stamatis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.25/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory]
2023-09-14 15:03:08,732 WARN [Time-limited test] common.TezUtils (TezUtils.java:logEntryIfLarge(237)) - Property 'testLargeValue' is unusually big (67108886 bytes); large payload may lead to OOM.
2023-09-14 15:03:08,841 INFO [Time-limited test] common.TezUtils (TezUtils.java:logEntryIfLarge(239)) - Large property 'testLargeValue': ABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJKLMNOPQRSTUVWXYZABCDE...
Additionally, I added a `tez-site.xml` file under `tez-common/test/resources` and varied a bit the values for the new configs.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 22m 56s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 10m 44s | master passed |
| +1 :green_heart: | compile | 0m 38s | master passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | compile | 0m 36s | master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | checkstyle | 1m 22s | master passed |
| +1 :green_heart: | javadoc | 0m 55s | master passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 42s | master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +0 :ok: | spotbugs | 1m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 47s | master passed |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 0m 24s | the patch passed |
| +1 :green_heart: | compile | 0m 27s | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | compile | 0m 22s | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | javac | 0m 22s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 15s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | findbugs | 1m 9s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 2m 17s | tez-api in the patch passed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| 46m 47s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/308 |
| JIRA Issue | TEZ-4503 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 3a8090d8b08e 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 7855c1fe0 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| whitespace | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/1/artifact/out/whitespace-eol.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/1/testReport/ |
| Max. process+thread count | 620 (vs. ulimit of 5500) |
| modules | C: tez-api U: tez-api |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/1/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 18s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| _ master Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 9m 57s | master passed |
| +1 :green_heart: | compile | 0m 35s | master passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | compile | 0m 35s | master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | checkstyle | 0m 37s | master passed |
| +1 :green_heart: | javadoc | 0m 45s | master passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 42s | master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +0 :ok: | spotbugs | 1m 49s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 47s | master passed |
| _ Patch Compile Tests _ | |||
| +1 :green_heart: | mvninstall | 0m 24s | the patch passed |
| +1 :green_heart: | compile | 0m 27s | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javac | 0m 27s | the patch passed |
| +1 :green_heart: | compile | 0m 23s | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | javac | 0m 23s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 14s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javadoc | 0m 26s | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | findbugs | 1m 9s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 2m 17s | tez-api in the patch passed. |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| 22m 26s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/308 |
| JIRA Issue | TEZ-4503 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile |
| uname | Linux 9309314f74f7 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 7855c1fe0 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| whitespace | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/2/artifact/out/whitespace-eol.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/2/testReport/ |
| Max. process+thread count | 571 (vs. ulimit of 5500) |
| modules | C: tez-api U: tez-api |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/2/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 4m 52s | Docker failed to build yetus/tez:86b11997b. |
| Subsystem | Report/Notes |
|---|---|
| GITHUB PR | https://github.com/apache/tez/pull/308 |
| JIRA Issue | TEZ-4503 |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/3/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
:broken_heart: -1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 0m 0s | Docker mode activated. |
| -1 :x: | docker | 0m 7s | Docker failed to build yetus/tez:86b11997b. |
| Subsystem | Report/Notes |
|---|---|
| GITHUB PR | https://github.com/apache/tez/pull/308 |
| JIRA Issue | TEZ-4503 |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/4/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
@abstractdog Can you please have a look in this PR when you get the chance. Thanks!
:confetti_ball: +1 overall
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| +0 :ok: | reexec | 24m 52s | Docker mode activated. |
| _ Prechecks _ | |||
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
| _ master Compile Tests _ | |||
| +0 :ok: | mvndep | 12m 46s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 15m 43s | master passed |
| +1 :green_heart: | compile | 3m 38s | master passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | compile | 3m 19s | master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | checkstyle | 2m 38s | master passed |
| +1 :green_heart: | javadoc | 2m 44s | master passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javadoc | 2m 21s | master passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +0 :ok: | spotbugs | 5m 47s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 8m 22s | master passed |
| -0 :warning: | patch | 6m 8s | Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary. |
| _ Patch Compile Tests _ | |||
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 46s | the patch passed |
| +1 :green_heart: | compile | 3m 36s | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javac | 3m 36s | the patch passed |
| +1 :green_heart: | compile | 3m 21s | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | javac | 3m 21s | the patch passed |
| -0 :warning: | checkstyle | 0m 31s | tez-api: The patch generated 1 new + 72 unchanged - 1 fixed = 73 total (was 73) |
| +1 :green_heart: | checkstyle | 0m 26s | tez-common: The patch generated 0 new + 14 unchanged - 1 fixed = 14 total (was 15) |
| -0 :warning: | checkstyle | 0m 57s | root: The patch generated 1 new + 86 unchanged - 2 fixed = 87 total (was 88) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 :green_heart: | javadoc | 2m 22s | the patch passed with JDK Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 |
| +1 :green_heart: | javadoc | 2m 17s | the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| +1 :green_heart: | findbugs | 7m 54s | the patch passed |
| _ Other Tests _ | |||
| +1 :green_heart: | unit | 2m 36s | tez-api in the patch passed. |
| +1 :green_heart: | unit | 0m 44s | tez-common in the patch passed. |
| +1 :green_heart: | unit | 75m 59s | root in the patch passed. |
| +1 :green_heart: | asflicense | 1m 27s | The patch does not generate ASF License warnings. |
| 186m 40s |
| Subsystem | Report/Notes |
|---|---|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/tez/pull/308 |
| JIRA Issue | TEZ-4503 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle |
| uname | Linux ff9dd343b5c7 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/tez.sh |
| git revision | master / 51d6f5396 |
| Default Java | Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20.1+1-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~22.04.1-b05 |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/5/artifact/out/diff-checkstyle-tez-api.txt |
| checkstyle | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/5/artifact/out/diff-checkstyle-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/5/testReport/ |
| Max. process+thread count | 1589 (vs. ulimit of 5500) |
| modules | C: tez-api tez-common . U: . |
| Console output | https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-308/5/console |
| versions | git=2.34.1 maven=3.6.3 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.