tez icon indicating copy to clipboard operation
tez copied to clipboard

TEZ-4457. tez.task.launch.cmd-opts default value is not really used b…

Open qijiale76 opened this issue 2 years ago • 6 comments

…y default.

qijiale76 avatar Nov 28 '22 07:11 qijiale76

The default value(jdk8) of tez.task.launch.cmd-opts is -XX:+PrintGCDetails -verbose:gc -XX:+PrintGCTimeStamps -XX:+UseNUMA -XX:+UseParallelGC. It is useful and should be really used by defalut.

qijiale76 avatar Nov 28 '22 07:11 qijiale76

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 32m 42s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart: mvninstall 15m 6s master passed
+1 :green_heart: compile 0m 52s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: compile 0m 50s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: checkstyle 1m 12s master passed
+1 :green_heart: javadoc 1m 3s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javadoc 0m 55s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 :ok: spotbugs 1m 38s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 37s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 23s the patch passed
+1 :green_heart: compile 0m 25s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javac 0m 25s the patch passed
+1 :green_heart: compile 0m 23s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: javac 0m 23s the patch passed
+1 :green_heart: checkstyle 0m 14s the patch passed
+1 :green_heart: whitespace 0m 1s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 51s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javadoc 1m 12s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: findbugs 1m 2s the patch passed
_ Other Tests _
-1 :x: unit 2m 14s tez-api in the patch failed.
+1 :green_heart: asflicense 0m 14s The patch does not generate ASF License warnings.
62m 6s
Reason Tests
Failed junit tests tez.client.TestTezClientUtils
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/251
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 42b9f7ab5225 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 2fd7df4cf
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/artifact/out/patch-unit-tez-api.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/testReport/
Max. process+thread count 358 (vs. ulimit of 5500)
modules C: tez-api U: tez-api
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Nov 28 '22 08:11 tez-yetus

:confetti_ball: +1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
+1 :green_heart: test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ master Compile Tests _
+1 :green_heart: mvninstall 15m 12s master passed
+1 :green_heart: compile 0m 47s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: compile 0m 46s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: checkstyle 1m 17s master passed
+1 :green_heart: javadoc 0m 56s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javadoc 0m 54s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 :ok: spotbugs 1m 36s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 34s master passed
_ Patch Compile Tests _
+1 :green_heart: mvninstall 0m 23s the patch passed
+1 :green_heart: compile 0m 24s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javac 0m 24s the patch passed
+1 :green_heart: compile 0m 22s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: javac 0m 22s the patch passed
+1 :green_heart: checkstyle 0m 13s the patch passed
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: javadoc 0m 25s the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javadoc 0m 27s the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: findbugs 0m 58s the patch passed
_ Other Tests _
+1 :green_heart: unit 2m 13s tez-api in the patch passed.
+1 :green_heart: asflicense 0m 16s The patch does not generate ASF License warnings.
28m 34s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/251
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs checkstyle compile
uname Linux 8356ee7557e6 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 2fd7df4cf
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/2/testReport/
Max. process+thread count 693 (vs. ulimit of 5500)
modules C: tez-api U: tez-api
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-251/2/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Nov 28 '22 10:11 tez-yetus

thanks for this patch @qijiale76 can you please add a unit test that validates this issue and the resolution? a recent commit on cmd opts might give you ideas on that: https://github.com/apache/tez/commit/06fff5c9c

abstractdog avatar Nov 28 '22 11:11 abstractdog

cc: @qijiale76 , can you address my comment above?

abstractdog avatar Jun 20 '23 05:06 abstractdog

cc: @qijiale76 , can you address my comment above?

Thanks for your comment, sorry I forgot it eariler, I'll add this unit test this week

qijiale76 avatar Jun 20 '23 06:06 qijiale76