tez icon indicating copy to clipboard operation
tez copied to clipboard

TEZ-4387: use new doclet API in Java 9+

Open LA-Toth opened this issue 3 years ago • 15 comments

LA-Toth avatar Feb 11 '22 09:02 LA-Toth

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 3s Maven dependency ordering for branch
+1 :green_heart: mvninstall 9m 29s master passed
+1 :green_heart: compile 1m 52s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: compile 1m 51s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 24s master passed
+1 :green_heart: javadoc 1m 29s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 1m 15s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 36s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 :ok: findbugs 1m 17s branch/tez-ui no findbugs output file (findbugsXml.xml)
+0 :ok: findbugs 0m 51s tez-tools in master has 2 extant findbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 12s Maven dependency ordering for patch
-1 :x: mvninstall 0m 23s tez-javadoc-tools-base in the patch failed.
-1 :x: compile 0m 23s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.
-1 :x: javac 0m 23s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.
-1 :x: compile 0m 23s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: javac 0m 23s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 :green_heart: checkstyle 0m 19s The patch passed checkstyle in tez-ui
+1 :green_heart: checkstyle 0m 23s The patch passed checkstyle in tez-tools
-0 :warning: checkstyle 0m 21s tez-tools/tez-javadoc-tools-base-jdk8: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)
+1 :green_heart: checkstyle 0m 19s tez-tools/tez-javadoc-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
-0 :warning: checkstyle 0m 21s tez-tools/tez-javadoc-tools-base: The patch generated 26 new + 0 unchanged - 0 fixed = 26 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 8s The patch has no ill-formed XML file.
-1 :x: javadoc 0m 29s tez-tools in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.
-1 :x: javadoc 0m 20s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.
+1 :green_heart: javadoc 1m 53s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: findbugs 0m 52s tez-ui has no data from findbugs
-1 :x: findbugs 0m 35s tez-tools/tez-javadoc-tools cannot run convertXmlToText from findbugs
-1 :x: findbugs 0m 23s tez-javadoc-tools-base in the patch failed.
_ Other Tests _
+1 :green_heart: unit 1m 57s tez-ui in the patch passed.
+1 :green_heart: unit 3m 8s tez-tools in the patch passed.
+1 :green_heart: unit 0m 25s tez-javadoc-tools-base-jdk8 in the patch passed.
+1 :green_heart: unit 0m 24s tez-javadoc-tools in the patch passed.
-1 :x: unit 0m 23s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: asflicense 1m 49s The patch does not generate ASF License warnings.
53m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux b48706801f94 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 7b66d3da7
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-javadoc-tez-tools-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-javadoc-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/testReport/
Max. process+thread count 866 (vs. ulimit of 5500)
modules C: tez-ui tez-tools tez-tools/tez-javadoc-tools-base-jdk8 tez-tools/tez-javadoc-tools tez-tools/tez-javadoc-tools-base U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/1/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Feb 11 '22 10:02 tez-yetus

left some comments also, could you please make a simple validity check with javadocs on JDK17?

mvn javadoc:javadoc
#take a look at for example tez-api/target/site/apidocs/index.html

abstractdog avatar Feb 18 '22 09:02 abstractdog

It seems that in JDK 11 the documentation generation is quite buggy, which is a known issue and fixed in JDK 13. SO link: https://stackoverflow.com/questions/62531431/exit-code-1-javadoc-error-the-code-being-documented-uses-modules-but possible OpenJDK tickets: https://bugs.openjdk.java.net/browse/JDK-8212233 and https://bugs.openjdk.java.net/browse/JDK-8217177

With Java 17 the documentation was generated successfully and believable, so I go further with the JDK17-only version.

LA-Toth avatar Feb 22 '22 07:02 LA-Toth

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 26m 28s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 1s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 26s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 44s master passed
+1 :green_heart: compile 0m 59s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: compile 1m 0s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 8s master passed
+1 :green_heart: javadoc 1m 6s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 0m 48s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 35s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 :ok: findbugs 1m 14s tez-tools in master has 2 extant findbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 11s Maven dependency ordering for patch
-1 :x: mvninstall 0m 11s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: compile 1m 1s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javac 1m 1s the patch passed
-1 :x: compile 0m 12s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: javac 0m 12s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 :green_heart: checkstyle 0m 9s tez-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
+1 :green_heart: checkstyle 0m 7s tez-tools/tez-javadoc-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
-0 :warning: checkstyle 0m 10s tez-tools/tez-javadoc-tools-base: The patch generated 26 new + 0 unchanged - 0 fixed = 26 total (was 0)
-0 :warning: checkstyle 0m 8s tez-tools/tez-javadoc-tools-base-jdk8: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 8s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 0m 49s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 0m 42s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: findbugs 0m 23s tez-tools/tez-javadoc-tools cannot run convertXmlToText from findbugs
-1 :x: findbugs 0m 11s tez-javadoc-tools-base in the patch failed.
_ Other Tests _
+1 :green_heart: unit 2m 50s tez-tools in the patch passed.
+1 :green_heart: unit 0m 12s tez-javadoc-tools in the patch passed.
-1 :x: unit 0m 11s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: unit 0m 13s tez-javadoc-tools-base-jdk8 in the patch passed.
+1 :green_heart: asflicense 0m 35s The patch does not generate ASF License warnings.
61m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux 9e82bf1e5d33 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 5241f58a5
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/testReport/
Max. process+thread count 875 (vs. ulimit of 5500)
modules C: tez-tools tez-tools/tez-javadoc-tools tez-tools/tez-javadoc-tools-base tez-tools/tez-javadoc-tools-base-jdk8 U: tez-tools
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Feb 22 '22 09:02 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 1m 31s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+0 :ok: shelldocs 0m 0s Shelldocs was not available.
+1 :green_heart: @author 0m 1s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 46s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 11s master passed
+1 :green_heart: compile 4m 42s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: compile 4m 45s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 2m 33s master passed
+1 :green_heart: javadoc 4m 20s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 3m 31s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 6m 13s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 :ok: findbugs 0m 51s tez-tools in master has 2 extant findbugs warnings.
+0 :ok: findbugs 6m 8s root in master has 2 extant findbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 15s Maven dependency ordering for patch
-1 :x: mvninstall 0m 24s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: compile 5m 29s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javac 5m 29s the patch passed
-1 :x: compile 0m 24s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: javac 0m 24s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 :green_heart: checkstyle 0m 25s The patch passed checkstyle in tez-api
+1 :green_heart: checkstyle 0m 21s The patch passed checkstyle in tez-protobuf-history-plugin
+1 :green_heart: checkstyle 0m 26s tez-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
+1 :green_heart: checkstyle 0m 18s tez-tools/tez-javadoc-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
+1 :green_heart: checkstyle 0m 48s root: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
-0 :warning: checkstyle 0m 19s tez-tools/tez-javadoc-tools-base: The patch generated 26 new + 0 unchanged - 0 fixed = 26 total (was 0)
-0 :warning: checkstyle 0m 22s tez-tools/tez-javadoc-tools-base-jdk8: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)
+1 :green_heart: shellcheck 0m 0s The patch generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 12s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 4m 52s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 4m 28s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: findbugs 0m 35s tez-tools/tez-javadoc-tools cannot run convertXmlToText from findbugs
-1 :x: findbugs 0m 24s tez-javadoc-tools-base in the patch failed.
_ Other Tests _
+1 :green_heart: unit 2m 17s tez-api in the patch passed.
+1 :green_heart: unit 0m 37s tez-protobuf-history-plugin in the patch passed.
+1 :green_heart: unit 3m 3s tez-tools in the patch passed.
+1 :green_heart: unit 0m 24s tez-javadoc-tools in the patch passed.
+1 :green_heart: unit 69m 42s root in the patch passed.
-1 :x: unit 0m 27s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: unit 0m 26s tez-javadoc-tools-base-jdk8 in the patch passed.
+1 :green_heart: asflicense 2m 53s The patch does not generate ASF License warnings.
171m 12s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux 7b4013cc50f2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 5241f58a5
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/testReport/
Max. process+thread count 2099 (vs. ulimit of 5500)
modules C: tez-api tez-plugins/tez-protobuf-history-plugin tez-tools tez-tools/tez-javadoc-tools . tez-tools/tez-javadoc-tools-base tez-tools/tez-javadoc-tools-base-jdk8 U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/2/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.1 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Feb 22 '22 11:02 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 46s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 5s Maven dependency ordering for branch
+1 :green_heart: mvninstall 10m 12s master passed
+1 :green_heart: compile 1m 3s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: compile 0m 58s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 2s master passed
+1 :green_heart: javadoc 1m 7s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 0m 48s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 34s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 :ok: findbugs 1m 19s tez-tools in master has 2 extant findbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 13s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: compile 1m 10s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javac 1m 10s the patch passed
-1 :x: compile 0m 11s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: javac 0m 11s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
+1 :green_heart: checkstyle 0m 11s tez-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
+1 :green_heart: checkstyle 0m 6s tez-tools/tez-javadoc-tools: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25)
-0 :warning: checkstyle 0m 9s tez-tools/tez-javadoc-tools-base: The patch generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
-0 :warning: checkstyle 0m 9s tez-tools/tez-javadoc-tools-base-jdk8: The patch generated 25 new + 0 unchanged - 0 fixed = 25 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 9s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 0m 56s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 0m 44s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: findbugs 0m 25s tez-tools/tez-javadoc-tools cannot run convertXmlToText from findbugs
-1 :x: findbugs 0m 12s tez-javadoc-tools-base in the patch failed.
_ Other Tests _
+1 :green_heart: unit 2m 57s tez-tools in the patch passed.
+1 :green_heart: unit 0m 12s tez-javadoc-tools in the patch passed.
-1 :x: unit 0m 12s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: unit 0m 12s tez-javadoc-tools-base-jdk8 in the patch passed.
+1 :green_heart: asflicense 0m 38s The patch does not generate ASF License warnings.
36m 13s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux e5c4699ab061 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / fa74b9587
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/testReport/
Max. process+thread count 877 (vs. ulimit of 5500)
modules C: tez-tools tez-tools/tez-javadoc-tools tez-tools/tez-javadoc-tools-base tez-tools/tez-javadoc-tools-base-jdk8 U: tez-tools
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Feb 25 '22 13:02 tez-yetus

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 19s Maven dependency ordering for branch
+1 :green_heart: mvninstall 9m 30s master passed
+1 :green_heart: compile 1m 0s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: compile 1m 0s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 :green_heart: checkstyle 1m 8s master passed
+1 :green_heart: javadoc 1m 7s master passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 0m 52s master passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+0 :ok: spotbugs 0m 35s Used deprecated FindBugs config; considering switching to SpotBugs.
+0 :ok: findbugs 1m 15s tez-tools in master has 2 extant findbugs warnings.
_ Patch Compile Tests _
+0 :ok: mvndep 0m 9s Maven dependency ordering for patch
-1 :x: mvninstall 0m 11s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: compile 0m 59s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javac 0m 59s the patch passed
-1 :x: compile 0m 11s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-1 :x: javac 0m 11s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.
-0 :warning: checkstyle 0m 19s tez-tools: The patch generated 357 new + 4 unchanged - 21 fixed = 361 total (was 25)
-0 :warning: checkstyle 0m 17s tez-tools/tez-javadoc-tools: The patch generated 357 new + 4 unchanged - 21 fixed = 361 total (was 25)
-0 :warning: checkstyle 0m 10s tez-tools/tez-javadoc-tools-base: The patch generated 47 new + 0 unchanged - 0 fixed = 47 total (was 0)
-0 :warning: checkstyle 0m 13s tez-tools/tez-javadoc-tools-base-jdk8: The patch generated 192 new + 0 unchanged - 0 fixed = 192 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 8s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 0m 54s the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 :green_heart: javadoc 0m 45s the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
-1 :x: findbugs 0m 10s tez-javadoc-tools-base in the patch failed.
_ Other Tests _
+1 :green_heart: unit 2m 48s tez-tools in the patch passed.
+1 :green_heart: unit 0m 13s tez-javadoc-tools in the patch passed.
-1 :x: unit 0m 11s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: unit 0m 12s tez-javadoc-tools-base-jdk8 in the patch passed.
+1 :green_heart: asflicense 0m 37s The patch does not generate ASF License warnings.
35m 23s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux 0e4e0911f064 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / fa74b9587
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/diff-checkstyle-tez-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/testReport/
Max. process+thread count 878 (vs. ulimit of 5500)
modules C: tez-tools tez-tools/tez-javadoc-tools tez-tools/tez-javadoc-tools-base tez-tools/tez-javadoc-tools-base-jdk8 U: tez-tools
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/5/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Feb 28 '22 10:02 tez-yetus

@LA-Toth: is there any pending work on this PR I can help with?

abstractdog avatar Nov 17 '22 10:11 abstractdog

I had only one problem, the tests are too strict and cannot handle properly my solution. So I always get -1 for something. I don't think it's an error in my PR, I can't do anything.

LA-Toth avatar Nov 22 '22 09:11 LA-Toth

okay thanks, let me take a look next week

abstractdog avatar Nov 26 '22 10:11 abstractdog

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 41m 13s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 56s Maven dependency ordering for branch
+1 :green_heart: mvninstall 11m 59s master passed
+1 :green_heart: compile 1m 12s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: compile 1m 15s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 :green_heart: checkstyle 1m 23s master passed
+1 :green_heart: javadoc 1m 11s master passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 :green_heart: javadoc 0m 53s master passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+0 :ok: spotbugs 0m 35s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 51s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 16s Maven dependency ordering for patch
-1 :x: mvninstall 0m 25s tez-tools in the patch failed.
-1 :x: mvninstall 0m 15s tez-javadoc-tools in the patch failed.
-1 :x: mvninstall 0m 6s tez-javadoc-tools-base in the patch failed.
-1 :x: mvninstall 0m 8s tez-javadoc-tools-base-jdk8 in the patch failed.
-1 :x: compile 0m 6s tez-tools in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: compile 0m 11s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: compile 0m 6s tez-javadoc-tools-base in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: compile 0m 7s tez-javadoc-tools-base-jdk8 in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javac 0m 6s tez-tools in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javac 0m 11s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javac 0m 6s tez-javadoc-tools-base in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javac 0m 7s tez-javadoc-tools-base-jdk8 in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: compile 0m 21s tez-tools in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: compile 0m 12s tez-javadoc-tools in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: compile 0m 6s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: compile 0m 6s tez-javadoc-tools-base-jdk8 in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: javac 0m 21s tez-tools in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: javac 0m 12s tez-javadoc-tools in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: javac 0m 6s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: javac 0m 6s tez-javadoc-tools-base-jdk8 in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-0 :warning: checkstyle 0m 10s The patch fails to run checkstyle in tez-tools
-0 :warning: checkstyle 0m 9s The patch fails to run checkstyle in tez-javadoc-tools
-0 :warning: checkstyle 0m 6s The patch fails to run checkstyle in tez-javadoc-tools-base
-0 :warning: checkstyle 0m 4s The patch fails to run checkstyle in tez-javadoc-tools-base-jdk8
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 8s The patch has no ill-formed XML file.
-1 :x: javadoc 0m 5s tez-tools in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javadoc 0m 8s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javadoc 0m 8s tez-javadoc-tools-base in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javadoc 0m 7s tez-javadoc-tools-base-jdk8 in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 :x: javadoc 0m 6s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: javadoc 0m 6s tez-javadoc-tools-base-jdk8 in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
-1 :x: findbugs 0m 36s tez-tools in the patch failed.
-1 :x: findbugs 0m 12s tez-javadoc-tools in the patch failed.
-1 :x: findbugs 0m 10s tez-javadoc-tools-base in the patch failed.
-1 :x: findbugs 0m 6s tez-javadoc-tools-base-jdk8 in the patch failed.
_ Other Tests _
-1 :x: unit 2m 53s tez-tools in the patch failed.
-1 :x: unit 0m 13s tez-javadoc-tools in the patch failed.
-1 :x: unit 0m 8s tez-javadoc-tools-base in the patch failed.
-1 :x: unit 0m 8s tez-javadoc-tools-base-jdk8 in the patch failed.
+1 :green_heart: asflicense 0m 45s The patch does not generate ASF License warnings.
77m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux c5570d39899a 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 39e5a8e71
Default Java Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-mvninstall-tez-tools.txt
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools.txt
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base-jdk8.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdk8-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdk8-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdk8-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdk8-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/buildtool-patch-checkstyle-tez-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/buildtool-patch-checkstyle-tez-tools_tez-javadoc-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/buildtool-patch-checkstyle-tez-tools_tez-javadoc-tools-base.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/buildtool-patch-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-javadoc-tez-tools-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-javadoc-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-javadoc-tez-tools_tez-javadoc-tools-base-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-javadoc-tez-tools_tez-javadoc-tools-base-jdk8-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-javadoc-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
javadoc https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-javadoc-tez-tools_tez-javadoc-tools-base-jdk8-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-findbugs-tez-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base-jdk8.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-unit-tez-tools.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-unit-tez-tools_tez-javadoc-tools.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base-jdk8.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/testReport/
Max. process+thread count 795 (vs. ulimit of 5500)
modules C: tez-tools tez-tools/tez-javadoc-tools tez-tools/tez-javadoc-tools-base tez-tools/tez-javadoc-tools-base-jdk8 U: tez-tools
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/3/console
versions git=2.25.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Feb 01 '23 21:02 tez-yetus

@LA-Toth: is there a chance you can check the patch with JDK11? I tried your commits at https://github.com/apache/tez/pull/296 and I found that the new github action step fails for building it on JDK11 the goal here is to remain compatible with JDK8 + JDK11, I'm hoping it's possible with easy changes

abstractdog avatar Jun 23 '23 12:06 abstractdog

@LA-Toth: is there a chance you can check the patch with JDK11? I tried your commits at #296 and I found that the new github action step fails for building it on JDK11 the goal here is to remain compatible with JDK8 + JDK11, I'm hoping it's possible with easy changes

It works with JDK 11, as I see, at least locally. I just missed the version bump in pom.xml files.

LA-Toth avatar Jun 23 '23 13:06 LA-Toth

:broken_heart: -1 overall

Vote Subsystem Runtime Comment
+0 :ok: reexec 27m 6s Docker mode activated.
_ Prechecks _
+1 :green_heart: dupname 0m 0s No case conflicting files found.
+1 :green_heart: @author 0m 0s The patch does not contain any @author tags.
-1 :x: test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+0 :ok: mvndep 5m 24s Maven dependency ordering for branch
+1 :green_heart: mvninstall 7m 23s master passed
+1 :green_heart: compile 0m 58s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 :green_heart: compile 0m 55s master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09
+1 :green_heart: checkstyle 0m 43s master passed
+1 :green_heart: javadoc 0m 43s master passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 :green_heart: javadoc 0m 41s master passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09
+0 :ok: spotbugs 0m 33s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 :green_heart: findbugs 1m 26s master passed
_ Patch Compile Tests _
+0 :ok: mvndep 0m 10s Maven dependency ordering for patch
-1 :x: mvninstall 0m 20s tez-tools in the patch failed.
-1 :x: mvninstall 0m 11s tez-javadoc-tools in the patch failed.
-1 :x: mvninstall 0m 11s tez-javadoc-tools-base in the patch failed.
-1 :x: compile 0m 24s tez-tools in the patch failed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
-1 :x: compile 0m 12s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
-1 :x: javac 0m 24s tez-tools in the patch failed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
-1 :x: javac 0m 12s tez-javadoc-tools in the patch failed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.
-1 :x: compile 0m 20s tez-tools in the patch failed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.
-1 :x: compile 0m 12s tez-javadoc-tools in the patch failed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.
-1 :x: compile 0m 10s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.
-1 :x: javac 0m 20s tez-tools in the patch failed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.
-1 :x: javac 0m 12s tez-javadoc-tools in the patch failed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.
-1 :x: javac 0m 10s tez-javadoc-tools-base in the patch failed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.
-0 :warning: checkstyle 0m 9s The patch fails to run checkstyle in tez-tools
-0 :warning: checkstyle 0m 7s The patch fails to run checkstyle in tez-javadoc-tools
-0 :warning: checkstyle 0m 8s tez-tools/tez-javadoc-tools-base: The patch generated 47 new + 0 unchanged - 0 fixed = 47 total (was 0)
-0 :warning: checkstyle 0m 11s tez-tools/tez-javadoc-tools-base-jdk8: The patch generated 190 new + 0 unchanged - 0 fixed = 190 total (was 0)
+1 :green_heart: whitespace 0m 0s The patch has no whitespace issues.
+1 :green_heart: xml 0m 7s The patch has no ill-formed XML file.
+1 :green_heart: javadoc 0m 34s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1
+1 :green_heart: javadoc 0m 34s the patch passed with JDK Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09
-1 :x: findbugs 0m 31s tez-tools in the patch failed.
-1 :x: findbugs 0m 12s tez-javadoc-tools in the patch failed.
-1 :x: findbugs 0m 10s tez-javadoc-tools-base in the patch failed.
_ Other Tests _
-1 :x: unit 2m 44s tez-tools in the patch failed.
-1 :x: unit 0m 11s tez-javadoc-tools in the patch failed.
-1 :x: unit 0m 11s tez-javadoc-tools-base in the patch failed.
+1 :green_heart: unit 0m 12s tez-javadoc-tools-base-jdk8 in the patch passed.
+1 :green_heart: asflicense 0m 30s The patch does not generate ASF License warnings.
56m 46s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/Dockerfile
GITHUB PR https://github.com/apache/tez/pull/187
JIRA Issue TEZ-4387
Optional Tests dupname asflicense javac javadoc unit xml compile spotbugs findbugs checkstyle
uname Linux 5149fe41507f 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 154fd341d
Default Java Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-mvninstall-tez-tools.txt
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools.txt
mvninstall https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-mvninstall-tez-tools_tez-javadoc-tools-base.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkUbuntu-11.0.19+7-post-Ubuntu-0ubuntu122.04.1.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools-jdkPrivateBuild-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkPrivateBuild-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.txt
compile https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools-jdkPrivateBuild-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-jdkPrivateBuild-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.txt
javac https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-compile-tez-tools_tez-javadoc-tools-base-jdkPrivateBuild-1.8.0_362-8u372-ga~us1-0ubuntu1~22.04-b09.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/buildtool-patch-checkstyle-tez-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/buildtool-patch-checkstyle-tez-tools_tez-javadoc-tools.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base.txt
checkstyle https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/diff-checkstyle-tez-tools_tez-javadoc-tools-base-jdk8.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-findbugs-tez-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools.txt
findbugs https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-findbugs-tez-tools_tez-javadoc-tools-base.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-unit-tez-tools.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-unit-tez-tools_tez-javadoc-tools.txt
unit https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/artifact/out/patch-unit-tez-tools_tez-javadoc-tools-base.txt
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/testReport/
Max. process+thread count 807 (vs. ulimit of 5500)
modules C: tez-tools tez-tools/tez-javadoc-tools tez-tools/tez-javadoc-tools-base tez-tools/tez-javadoc-tools-base-jdk8 U: tez-tools
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-187/4/console
versions git=2.34.1 maven=3.6.3 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

tez-yetus avatar Jun 23 '23 14:06 tez-yetus

this is strange, I wanted to test by building locally, but I can see that in jdk8 the problematic module is not included at all:

cd tez-tools
mvn --batch-mode clean test-compile -DskipTests=true
...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for tez-tools 0.10.3-SNAPSHOT:
[INFO]
[INFO] tez-tools .......................................... SUCCESS [  1.414 s]
[INFO] tez-perf-analyzer .................................. SUCCESS [  0.126 s]
[INFO] tez-job-analyzer ................................... SUCCESS [  8.361 s]
[INFO] tez-javadoc-tools .................................. SUCCESS [  1.323 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------

I expected tez-javadoc-tools-base-jdk8 to be included

mvn -version

Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63)
Maven home: /Users/laszlobodor/Applications/maven
Java version: 1.8.0_292, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
Default locale: en_HU, platform encoding: UTF-8
OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"

abstractdog avatar Jun 23 '23 15:06 abstractdog