tapestry-5 icon indicating copy to clipboard operation
tapestry-5 copied to clipboard

Published 20 hours ago • verified publisher icon apache

TAP5-2741: Update to Jakarta EE 9

Open vjlamp opened this issue 1 year ago • 5 comments

This is going to be a marathon, not a sprint. This first commit is not yet concerned with any of the Jakarta EE stuff. Actually, it's only about breaking up the build logic some more. A more broken-down build logic will hopefully make it easier to accommodate different JDK versions for building and also make it easier to produce the Jakarta EE variants. I created this draft PR at this early stage to share my progress with you guys.

I'm aware that even though all tests passed with this commit (locally, at least) I temporarily disabled some steps (Javadoc, Jacoco, and publishing, specifically.)

Looking forward to crossing the finish line after 42195 meters :) Hopefully alive, not dead.

vjlamp avatar Apr 26 '23 16:04 vjlamp

Ok

El El mié, abr. 26, 2023 a la(s) 12:27 p.m., Volker Lamp < @.***> escribió:

This is going to be a marathon, not a sprint. This first commit is not yet concerned with any of the Jakarta EE stuff. Actually, it's only about breaking up the build logic some more. A more broken-down build logic will hopefully make it easier to accommodate different JDK versions for building and also make it easier to produce the Jakarta EE variants. I created this draft PR at this early stage to share my progress with you guys.

I'm aware that even though all tests passed with this commit (locally, at least) I temporarily disabled some steps (Javadoc, Jacoco, and publishing, specifically.)

Looking forward to crossing the finish line after 42195 meters :) Hopefully alive, not dead.

You can view, comment on, or merge this pull request online at:

https://github.com/apache/tapestry-5/pull/38 Commit Summary

File Changes

(44 files https://github.com/apache/tapestry-5/pull/38/files)

Patch Links:

  • https://github.com/apache/tapestry-5/pull/38.patch
  • https://github.com/apache/tapestry-5/pull/38.diff

— Reply to this email directly, view it on GitHub https://github.com/apache/tapestry-5/pull/38, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOR3AGRYON76BQL532ZDQSTXDFEG5ANCNFSM6AAAAAAXMVYOJQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

hamerperez avatar Apr 28 '23 03:04 hamerperez

What is the state of this PR? How can i build the jakarta feature variant with the current build script?

derkoe avatar Sep 11 '23 13:09 derkoe

What is the state of this PR? How can i build the jakarta feature variant with the current build script?

Unfortunately, we are not there yet, i.e. you can't build the jakarta feature variant with the current build script at this time.

A posted a short summary on the dev mailing list a couple of months ago. While I'm still keen to get to this done, I haven't been able to allocate much time to this issue over the last few months.

vjlamp avatar Sep 11 '23 15:09 vjlamp

@vjlamp I have used a different approach in this PR: #43 (TAP5-2741: switch to Jakarta EE and Java 11).

I think it will not be possible to support both the old and new namespace with one branch because you have to change a lot (especially because of changes in dependencies). I think the best way would be to create a new Tapestry version (5.9 or 6.0) that support Jakarta EE and create a branch for 5.8 that still supports the old Java EE namespace.

derkoe avatar Sep 15 '23 06:09 derkoe

@derkoe Yes, that's what I concluded also. It'll probably be the 5.9 release, not a 6.x release anyway, as @thiagohp motivated. Thank you for suggesting #43, I'll check it out :)

vjlamp avatar Sep 15 '23 16:09 vjlamp