systemds icon indicating copy to clipboard operation
systemds copied to clipboard

[SYSTEMDS-3385] Integration of frontend with monitoring backend

Open MKehayov opened this issue 3 years ago • 13 comments

This change has the initial frontend application written in Angular. It is integrated with the backend so that both applications are communicating with REST requests, with this, coordinators and workers can be managed from the Angular app and real-time statistics can be displayed.

MKehayov avatar Jun 19 '22 19:06 MKehayov

Hi @MKehayov thanks a lot for the feature. you can add screenshots here too!

j143 avatar Jun 20 '22 16:06 j143

Sure @j143 here -

Screenshot from 2022-06-20 22-04-30 Screenshot from 2022-06-20 22-03-43 Screenshot from 2022-06-20 22-02-26 Screenshot from 2022-06-20 22-01-55 Screenshot from 2022-06-20 22-01-39

let me know if you think further changes are required for the initial implementation.

MKehayov avatar Jun 20 '22 20:06 MKehayov

thanks @MKehayov , I will tryout this feature with some experiments and let you know how it goes.

j143 avatar Jun 21 '22 12:06 j143

I have only verified the angular UI, (I will test the full functionality while running the federated experiments shortly.)

  1. we can customize README and add license!
  2. we can remove package-lock.json. Although, the standard practice is to include in a web repo, here we can keep the code concise by removing the generated code as much as possible.
  3. You can add documentation (like a small diagram of the data model if possible), so that people can easily extend it.
  4. Of course, as Sebastian mentioned let's add test for each component.
  5. Also, let only reveal the enough info in the logs - if need be we can extend it later.

Best, Janardhan

j143 avatar Jun 23 '22 15:06 j143

Hey, @j143 thank you for the points, my fixes on them are the following:

  1. I have added README files for the angular UI and backend, a license is included in the angular one.
  2. I agree, that it is a standard practice to have the package-lock in the repo, it is currently there, but let me know if I should remove it.
  3. Added in the README file of the backend and the API reference can be found in the angular README.
  4. I added at least one test for every component, they currently sum up to 36.
  5. I removed the logging of the errors in the StatsService, let me know where else you think we should remove the logs.

Best, Mito

MKehayov avatar Jun 25 '22 15:06 MKehayov

I agree, that it is a standard practice to have the package-lock in the repo, it is currently there, but let me know if I should remove it.

Yes, lets remove it.

j143 avatar Jun 28 '22 02:06 j143

I agree, that it is a standard practice to have the package-lock in the repo, it is currently there, but let me know if I should remove it.

Yes, lets remove it.

Done.

MKehayov avatar Jun 28 '22 07:06 MKehayov

I am facing issues with setting up the federated experiments, could not verify this complete feature at the moment. I will do this as soon as possible.

j143 avatar Jun 28 '22 13:06 j143

Hi @j143, did you manage to run and test the app, and if not, can I help with anything?

MKehayov avatar Jul 25 '22 06:07 MKehayov

Hi @j143, did you manage to run and test the app, and if not, can I help with anything?

can you help me set it up. my email is [email protected]

j143 avatar Jul 25 '22 08:07 j143

Hi @MKehayov - view is not responding/updating when I am trying to add either worker/coordinator.

j143 avatar Jul 30 '22 06:07 j143

Hey @j143 I found a bug, which also prevents the registering of worker/coordinator in the system, and pushed a fix for it, if this does not fix the problem for you, let me know. With the latest changes, I started an implementation of an event timeline for each worker and extended the worker dashboard itself, attached are some screenshots: Screenshot from 2022-07-29 13-27-58 Screenshot from 2022-07-30 11-00-40

MKehayov avatar Jul 30 '22 14:07 MKehayov

I tried the latest change set, 😃

  1. The worker, coordinator and event timeline looks good.
  2. Great work adding architecture, data model diagrams 📚
  3. and for npm run test I received the following:

image

Thanks for working on this feature.✨

j143 avatar Aug 13 '22 16:08 j143

Looks Good to me. 👍

Thanks a lot - @MKehayov. ✨🎉

j143 avatar Aug 18 '22 01:08 j143