superset icon indicating copy to clipboard operation
superset copied to clipboard

chore(deps): Remove redundant polished direct dependency

Open rusackas opened this issue 2 weeks ago • 3 comments

User description

Summary

This PR removes polished from direct dependencies since it's never imported directly and is already available as a transitive dependency through Storybook packages.

Analysis

Dependency analysis reveals:

  • Zero direct imports: No imports of polished found in src/, packages/, or plugins/
  • Already available transitively: Included through @storybook/addon-actions and @storybook/blocks
  • No build/config usage: Not referenced in webpack, babel, or other configuration files
  • Redundant listing: Having it as both direct and transitive dependency is unnecessary

Verification

# No direct imports found
$ rg "from ['\"]polished|import.*polished|require.*polished" src/ packages/ plugins/
# (no results)

# Still available through Storybook
$ npm ls polished
├─┬ @storybook/[email protected]
│ └── [email protected]
├─┬ @storybook/[email protected]
│ └─┬ @storybook/[email protected]
│   └── [email protected] deduped

Changes

  • Removed polished (^4.3.1) from package.json direct dependencies
  • Updated package-lock.json accordingly
  • Package remains available through transitive dependencies

Impact

  • Cleaner dependency tree: Reduces redundant dependencies
  • No functionality changes: Library still accessible where needed
  • Reduced maintenance: One less direct dependency to track and update

Testing

  • Frontend builds successfully
  • Storybook still functions correctly
  • No TypeScript or linting errors

🤖 Generated with Claude Code


CodeAnt-AI Description

Remove unused direct 'polished' dependency from frontend package

What Changed

  • Removed "polished" from superset-frontend package.json so it's no longer listed as a direct dependency
  • Updated package-lock.json to remove the direct entry
  • No functional change: "polished" remains available via Storybook, and frontend builds and Storybook were verified to work normally

Impact

✅ One fewer direct dependency to maintain ✅ No change to frontend builds or Storybook behavior ✅ package.json and lockfile now reflect actual usage

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

rusackas avatar Dec 04 '25 20:12 rusackas

CodeAnt AI is reviewing your PR.

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at [email protected].

bito-code-review[bot] avatar Dec 04 '25 20:12 bito-code-review[bot]

CodeAnt AI finished reviewing your PR.