apache
[SIP] Proposal for having an announcement banner
Please make sure you are familiar with the SIP process documented here. The SIP will be numbered by a committer upon acceptance.
[SIP] Proposal for having an announcement banner
Motivation
We wanted to tell users about announcements of varying severity. For example: when GBQ goes down or something, we could have a banner letting them know or even when theres maintenance or an upgrade for expected downtime.
Proposed Change
Theres going to be a button in settings bar that only admins should be able to see. There is also going to be a modal that pops up that allows the admins to set whatever message they want.
New or Changed Public Interfaces
There is going to be a new announcement model requiring a DB migration, an announcement API and some frontend modals and buttons to make this happen as noted in the screenshots.
Migration Plan and Compatibility
Migration needs to happen to get the announcement data in there
This seems similar to SIP-96 https://github.com/apache/superset/issues/24271
If you think that SIP covers the same bases, great! If not, could you enumerate the differences, i.e. what might be added to the existing SIP to cover your use cases?
Also, while many folks are big fans of that effort, it hasn't yet ben "adopted" since the SIP author has been unavailable to contribute it, so we'd welcome the effort if you want to take it on, and I can help steer the SIP through process.
@rusackas
It is really similar. I noticed it when i searched banner, but the title didn't click to me when it was related. Oops.
The main difference is that instead of a toast, it's a bar at the top. The other is that mine has a countdown timer to let user see how long until a patch for example.
Other than that, I've got way less features in mine... I dont have the "management" page where you can set multiple notifications and see what's expired. Mine is really just a simple barebones banner at the top that supports a singular notification one at a time with no automatic scheduling. Would you suggest I pull those extra feats here as well? Please advise me on how to approach. 🙏
Maybe they could use the same underpinnings, but each notification could have a config (radio button) to select "toast" or "banner"?
CC @kasiazjc for any design input...
I think we could consolidate the two sips, if you want to layer on to the old one.