superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(superset-frontend): Fixes for broken functionality when an application root is defined

Open martyngigg opened this issue 1 month ago • 6 comments

SUMMARY

Fixes for the settings menu:

  • includes app root in the link to the user information
  • removes old superset/fab_overrides template references. The templates were removed in #34093.
  • fixes 'Create chart' button on SQL lab interface in the presence of a non-empty application root

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Fixes #35027

  • [x] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

martyngigg avatar Nov 10 '25 17:11 martyngigg

Bito Review Skipped - Source Branch Not Found

Bito didn’t review this change because the pull request is no longer valid. It may have been merged, or the source/target branch may no longer exist.

bito-code-review[bot] avatar Nov 10 '25 17:11 bito-code-review[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.26%. Comparing base (b5cac47) to head (3400127). :warning: Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #36058       +/-   ##
===========================================
+ Coverage        0   68.26%   +68.26%     
===========================================
  Files           0      629      +629     
  Lines           0    46175    +46175     
  Branches        0     4998     +4998     
===========================================
+ Hits            0    31523    +31523     
- Misses          0    13402    +13402     
- Partials        0     1250     +1250     
Flag Coverage Δ
hive 43.88% <ø> (?)
mysql 67.38% <ø> (?)
postgres 67.43% <ø> (?)
presto 47.51% <ø> (?)
python 68.23% <ø> (?)
sqlite 67.04% <ø> (?)
unit 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 10 '25 18:11 codecov[bot]

Is there a way I can rerun a single check? I think "[Python-Integration / test-mysql" is flaky?

martyngigg avatar Nov 13 '25 10:11 martyngigg

Looks like CI passed (yay!) but there's a conflict to resolve (dang!).

rusackas avatar Nov 17 '25 22:11 rusackas

Looks like CI passed (yay!) but there's a conflict to resolve (dang!).

Thanks for nudge. Should be fixed now.

martyngigg avatar Nov 18 '25 09:11 martyngigg

@sadpandajoe Do you think it's possible this could make it into v6?

martyngigg avatar Dec 08 '25 15:12 martyngigg