fix: tag removal not working in dashboard properties modal
Fix: Tag Removal Not Working in Dashboard Properties Modal
Problem
- Tag removal works correctly in the Explore Properties Modal but fails in the Dashboard Properties Modal.
- Users can add tags, but cannot remove them using the clear functionality.
Solution
- Implemented the missing
handleClearTagsfunction in the Dashboard PropertiesModal. - Connected the
onClearprop to theAsyncSelectcomponent. - Mirrored the working implementation pattern used in the Explore PropertiesModal for consistency and reliability.
Testing
- All existing unit and integration tests pass.
- Manual testing confirms that tag removal now functions as expected in dashboard edit mode.
Additional Information
- [x] Fixes #33758
- [ ] Has associated issue
- [ ] Required feature flags
- [ ] Changes UI
- [ ] Includes DB Migration (SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Thanks for the PR! Running CI 🤞
@Vitor-Avila Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments
@Vitor-Avila Ephemeral environment spinning up at http://35.89.136.42:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
@Vitor-Avila Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments
Trying to spin up an ephemeral with TAGGING_SYSTEM enabled
@Vitor-Avila Ephemeral environment spinning up at http://44.247.50.122:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
@krikera I'm still able to reproduce the issue in the ephemeral (it seems that neither removing a single tag or fully cleaning the list is working). Are you able to double check?
I try on http://44.247.50.122:8080/ and I reproduce the issue
Superset adds some tags that we don't display. Is this overly-nuking things we shouldn't be clearing? (cc @Vitor-Avila)
Superset adds some tags that we don't display. Is this overly-nuking things we shouldn't be clearing? (cc @Vitor-Avila)
@rusackas that could be possible too (don't remember if I checked that) but last time I reviewed this fix in the ephemeral the issue was still reproducible. @krikera I'm wondering if you're seeing a different thing locally?