superset icon indicating copy to clipboard operation
superset copied to clipboard

fix: tag removal not working in dashboard properties modal

Open krikera opened this issue 6 months ago • 1 comments

Fix: Tag Removal Not Working in Dashboard Properties Modal

Problem

  • Tag removal works correctly in the Explore Properties Modal but fails in the Dashboard Properties Modal.
  • Users can add tags, but cannot remove them using the clear functionality.

Solution

  • Implemented the missing handleClearTags function in the Dashboard PropertiesModal.
  • Connected the onClear prop to the AsyncSelect component.
  • Mirrored the working implementation pattern used in the Explore PropertiesModal for consistency and reliability.

Testing

  • All existing unit and integration tests pass.
  • Manual testing confirms that tag removal now functions as expected in dashboard edit mode.

Additional Information

  • [x] Fixes #33758
  • [ ] Has associated issue
  • [ ] Required feature flags
  • [ ] Changes UI
  • [ ] Includes DB Migration (SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

krikera avatar Jun 12 '25 18:06 krikera

Thanks for the PR! Running CI 🤞

rusackas avatar Jun 13 '25 21:06 rusackas

@Vitor-Avila Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

github-actions[bot] avatar Jun 16 '25 02:06 github-actions[bot]

@Vitor-Avila Ephemeral environment spinning up at http://35.89.136.42:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Jun 16 '25 02:06 github-actions[bot]

@Vitor-Avila Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

github-actions[bot] avatar Jun 16 '25 17:06 github-actions[bot]

Trying to spin up an ephemeral with TAGGING_SYSTEM enabled

Vitor-Avila avatar Jun 16 '25 17:06 Vitor-Avila

@Vitor-Avila Ephemeral environment spinning up at http://44.247.50.122:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

github-actions[bot] avatar Jun 16 '25 17:06 github-actions[bot]

@krikera I'm still able to reproduce the issue in the ephemeral (it seems that neither removing a single tag or fully cleaning the list is working). Are you able to double check?

Vitor-Avila avatar Jun 16 '25 17:06 Vitor-Avila

I try on http://44.247.50.122:8080/ and I reproduce the issue

xavier-GitHub76 avatar Jun 27 '25 14:06 xavier-GitHub76

Superset adds some tags that we don't display. Is this overly-nuking things we shouldn't be clearing? (cc @Vitor-Avila)

rusackas avatar Aug 12 '25 20:08 rusackas

Superset adds some tags that we don't display. Is this overly-nuking things we shouldn't be clearing? (cc @Vitor-Avila)

@rusackas that could be possible too (don't remember if I checked that) but last time I reviewed this fix in the ephemeral the issue was still reproducible. @krikera I'm wondering if you're seeing a different thing locally?

Vitor-Avila avatar Aug 13 '25 00:08 Vitor-Avila