superset icon indicating copy to clipboard operation
superset copied to clipboard

fix(database): remove database

Open mcdogg17 opened this issue 6 months ago • 1 comments

Automatically delete related PVMs when removing database objects

SUMMARY

Previously, deleting database objects could fail due to existing relations with PermissionViewModel (PVM) entries, which caused integrity errors and prevented cleanup.

This PR introduces automatic deletion of all related PVMs during the removal of associated database objects to ensure proper cascading behavior

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • [ ] Has associated issue:
  • [ ] Required feature flags:
  • [ ] Changes UI
  • [ ] Includes DB Migration (follow approval process in SIP-59)
    • [ ] Migration is atomic, supports rollback & is backwards-compatible
    • [ ] Confirm DB migration upgrade and downgrade tested
    • [ ] Runtime estimates and downtime expectations provided
  • [ ] Introduces new feature or API
  • [ ] Removes existing feature or API

mcdogg17 avatar Jun 11 '25 09:06 mcdogg17

@supersetbot orglabel

mcdogg17 avatar Jun 11 '25 09:06 mcdogg17

Hi @mcdogg17 👋

This PR has been inactive for about 6 months and has failing CI tests (mysql, postgres, sqlite, unit-tests). Converting to draft until the test failures are resolved.

When you have time, please investigate and fix the failing tests. If you need help understanding the failures, feel free to ask!

If you're no longer able to work on this, let us know and we can close it or have someone else pick it up.

Thanks for your contribution!

rusackas avatar Dec 11 '25 22:12 rusackas