apache
fix: maintain pagination state on long echarts legends.
SUMMARY
Updates the ECharts handler to store (and restore) legend page, after someone clicks a legend item, so it doesn't hop back to Page 1.
Fixes https://github.com/apache/superset/issues/32387
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in SIP-59)
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.
Your admin can change your review schedule in the Korbit Console
![korbit-ai[bot] avatar](https://avatars.githubusercontent.com/in/322216?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rusackas Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rusackas Ephemeral environment spinning up at http://35.88.182.12:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.
Welp... that didn't QUITE work... seems the requestAnimationFrame is not working reliably. We could add a timeout, but this really seems to need an ECharts lifecyle (refreshed) hook of some sort.
Welp... that didn't QUITE work... seems the requestAnimationFrame is not working reliably. We could add a timeout, but this really seems to need an ECharts lifecyle (refreshed) hook of some sort.
Hey @rusackas
https://github.com/apache/superset/pull/27766/files I wrote this pr for this The problem with legend scrolling is our viz plugins do a complete re render , causing it to lose all local variables In this pr , I created a variable outside the Viz plugin , which worked out , At that time , i wasnt really good with the pr flow so wasnt able to get this pass
But maybe we can use this pr as reference
